Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Moving a sketch to another folder should move all files #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
facchinm wants to merge 1 commit into arduino:master from facchinm:movesketch_partial

Conversation

Copy link
Member

@facchinm facchinm commented Jun 21, 2017

Fixes #6402

per1234 reacted with thumbs up emoji
Copy link
Collaborator

per1234 commented Jun 24, 2017 •
edited
Loading

I just wanted to comment that, even if this PR doesn't fix #6402, it is a useful improvement. The previous behavior of only moving the primary sketch file regularly caused problems for people who downloaded a multi-file sketch from GitHub when that sketch is in the root of the repository. GitHub appends the branch name to the sketch folder, which forces the move, and breaks the sketch.

Example of the previous behavior causing problems: Espressobar/arduino-grind-timer#2

@facchinm facchinm added this to the Release 1.8.4 milestone Jul 25, 2017
@facchinm facchinm modified the milestones: Release 1.8.4, Next Aug 18, 2017
Copy link
Member

cmaglie commented Aug 23, 2018

We are searching a better solution for this problem, for now the commit has been reverted.
Follow ups on #7909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /