-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Serial plotter remote commands #7461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serial plotter remote commands #7461
Conversation
madsdyd
commented
Apr 7, 2020
Is there a consensus about adding "remote commands" (this patch include them)", vs. e.g. the ability to be able to ignore some lines? Traditionally, "#" is often used to indicate a comment in text based data files. An initial suggestion could be to expand the SerialPlotter protocol to
- Ignore any line starting with "#"
- Interprent any line starting with "$" as a command to the serial plotter.
The reason for "$" being that it is often used indicate a command prompt.
madsdyd
commented
Apr 7, 2020
Status of the QA check is that it fails because
- The method
setNewBufferCapacity
assigns to one of its parameters. - Line 326 needs to be changed from
if (commands.equals("CLEAR")) {
toif ("CLEAR".equals(commands)) {
Both are trivial to fix
Position literals first in String comparisons in message
use also for size command a seperate function
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
✅ WilhelmWiens
❌ Wilhelm Wiens
Wilhelm Wiens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
stefan123t
commented
Apr 14, 2022
Thanks for adding the Serial Plotter with Labels and Commands to the Arduino IDE!
- I am trying to find the Serial Plotter protocol documentation time and again. Here is PDF documentation by @chromhelm and here are the official markdown docs as well as a suggestion by @per1234 to enhance / update existing examples with labels
Regarding remote commands and comments as described in this PR:
Is there a consensus about adding "remote commands" (this patch include them)", vs. e.g. the ability to be able to ignore some lines? Traditionally, "#" is often used to indicate a comment in text based data files. An initial suggestion could be to expand the SerialPlotter protocol to
* Ignore any line starting with "#"
-
I agree that
#
is almost ubiquitious for comments along with optional//
line comments and/* */
multiline comments. -
The command line should be part of a comment, e.g. something like a shebang:
# $ CLEAR;
or#% $ SIZE 5000,500;
-
There are feature requests to ignore lines Support a comment character to ignore incoming text lines arduino-serial-plotter-webapp#28 and adding a filter / regex for plotting only specific interesting lines Mark interesting lines arduino-serial-plotter-webapp#21 .
This adds remote command to set the size and clear the plot area.
The commands are send like this:
#CLEAR
#SIZE:
size should be between 10 and 5000. This are hard coded limits for the plot size right now.