Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make serial plotter ringbuffer size configurable #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WilhelmWiens wants to merge 6 commits into arduino:master
base: master
Choose a base branch
Loading
from WilhelmWiens:serialPlotterConfigurableBuffer

Conversation

Copy link
Contributor

@WilhelmWiens WilhelmWiens commented Apr 10, 2018

No description provided.

Copy link
Member

@ArduinoBot build this please

@gvarisco gvarisco changed the title (削除) added the possebilety to change the ringbuffer size (削除ここまで) (追記) added the possibility to change the ringbuffer size (追記ここまで) Dec 12, 2018
@facchinm facchinm changed the title (削除) added the possibility to change the ringbuffer size (削除ここまで) (追記) Make serial plotter ringbuffer size configurable (追記ここまで) Sep 20, 2019
@facchinm facchinm added the SerialPlotter Tools > Serial Plotter label Sep 20, 2019
Copy link

madsdyd commented Apr 7, 2020

Just a note for others, and to stop myself from keep opening this issue: The PR (I think this should have been in the description):

Contains code to add a spinner to the Serial Plotter GUI, that allow to change the number of retained data points from the existing fixed 500 to a user chosen value between 10 and 5000.

However, the quality check fails, because there is:

  • An unused local variable legendLenght in paintComponent
  • The method setNewBufferCapacity assigns a new value to its parameter.

Both of these should be trivial to fix, but are there any maintainer (person with write access) that would be willing to merge this change?

Copy link

madsdyd commented Apr 7, 2020

So, does #7461 actually contain all the code in this issue as well?

Wilhelm Wiens and others added 2 commits April 9, 2020 13:10
Copy link
Contributor Author

Do not pull it yet. I have made faulty merge.

Copy link
Collaborator

per1234 commented Apr 14, 2020

This partially fixes arduino/arduino-serial-plotter-webapp#29 (and the remaining part may be wontfix)

Copy link

CLAassistant commented Apr 9, 2021
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ WilhelmWiens
✅ facchinm
❌ Wilhelm Wiens


Wilhelm Wiens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
SerialPlotter Tools > Serial Plotter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /