-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Make serial plotter ringbuffer size configurable #7454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make serial plotter ringbuffer size configurable #7454
Conversation
@ArduinoBot build this please
✅ Build completed.
Please test this code using one of the following:
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7454-BUILD-747-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7454-BUILD-747-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7454-BUILD-747-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7454-BUILD-747-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7454-BUILD-747-linuxarm.tar.xz
i️ The linuxarm
build is still experimental and may not be always available.
madsdyd
commented
Apr 7, 2020
Just a note for others, and to stop myself from keep opening this issue: The PR (I think this should have been in the description):
Contains code to add a spinner to the Serial Plotter GUI, that allow to change the number of retained data points from the existing fixed 500 to a user chosen value between 10 and 5000.
However, the quality check fails, because there is:
- An unused local variable
legendLenght
inpaintComponent
- The method
setNewBufferCapacity
assigns a new value to its parameter.
Both of these should be trivial to fix, but are there any maintainer (person with write access) that would be willing to merge this change?
madsdyd
commented
Apr 7, 2020
So, does #7461 actually contain all the code in this issue as well?
do not modify parameter in setNewBufferCapacity
Do not pull it yet. I have made faulty merge.
This partially fixes arduino/arduino-serial-plotter-webapp#29 (and the remaining part may be wontfix)
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
✅ WilhelmWiens
✅ facchinm
❌ Wilhelm Wiens
Wilhelm Wiens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
No description provided.