-
Notifications
You must be signed in to change notification settings - Fork 164
Adds support for Danish language #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardLayout_da_DK.cpp is Danish keyboard layout Keyboard.h references da_DK.cpp Keyboard_da_DK.h defines scan codes for Danish characters such as ÆØ.
Changed scan code for bslash as suggested by @edgar-bonnet
@edgar-bonet - this is the same code you reviewed previously, with the change to fix the backslash scan code. Apologies for any confusion.
|
Memory usage change @ 124a0cb
Click for full report table
Click for full report CSV |
edgar-bonet
edgar-bonet
approved these changes
Dec 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a typo in my name in the commit log, it all looks good to me.
|
Memory usage change @ 0904fb1
Click for full report table
Click for full report CSV |
Squashed and merged, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@facchinm please could you merge into Keyboard?
(.This pull requests supersedes previous pull request)