-
Notifications
You must be signed in to change notification settings - Fork 164
Add definitions for extra keys in national layouts #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new files Keyboard_{de_DE,es_ES,fr_FR,it_IT}.h add macro definitions for keys that could not be otherwise easily accessed with the library, such as "e with grave accent" in the French and Italian layouts. Only keys that produce either a non-ASCII character or a dead accent when used unmodified are listed. For instance, the "pound sign" is not listed in the Italian layout because, without the Shift modifier, that key prints a "3". The macros are named after the character produced by the unmodified key. For example, they key for the inverted exclamation and question marks in the Spanish layout is named `KEY_INVERTED_EXCLAMATION'. This mimics what has already been done for the Danish and Swedish layouts.
Memory usage change @ f066eeb
Click for full report table
Click for full report CSV
|
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests #58 and #60 added support for the Swedish and Danish keyboard layouts. Unlike the previously supported layouts, these new layouts came each with a header file that provides macro definitions for the keys that are not otherwise easily accessible. For example, Keyboard_sv_SE.h defines:
This pull request extends this to all the other supported layouts, namely de_DE, es_ES, fr_FR and it_IT. Note that en_US does not require such support, as all its keys are already readily accessible.
With this new definitions, every single key of a full-size PC keyboard can now be reached on every layout, either with
Keyboard.write(ASCII_char)
or by using one of the provided macros.Example: the following sketch prints "ça va être drôle!" on a French keyboard: