Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix warnings #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facchinm merged 2 commits into arduino-libraries:master from roleroz:master
Aug 4, 2023
Merged

Fix warnings #302

facchinm merged 2 commits into arduino-libraries:master from roleroz:master
Aug 4, 2023

Conversation

Copy link
Contributor

@roleroz roleroz commented May 29, 2023 •
edited by per1234
Loading

  • Reorder member initialization on BLELocalCharacteristic
  • Remove unused variables in:
    • HCIClass::tryResolveAddress
    • HCIClass::handleEventPkt (the whole else if statement did nothing)
    • L2CAPSignalingClass::handleSecurityData (one initialization should be inside of BLE_TRACE
    • BluetoothCryptoToolbox::f5
    • BluetoothCryptoToolbox::testAh
    • BluetoothCryptoToolbox::testg2
  • Uninitialized variable in L2CAPSignalingClass::handleSecurityData

There is still a warning in, which I cannot fix without more information (specifically what is the case 0x0A named):

ArduinoBLE/src/utility/HCI.cpp:991:7: warning: case value '10' not in enumerated type 'LE_META_EVENT' [-Wswitch]
 case 0x0A:{
 ^~~~

gmacario and ElectricRCAircraftGuy reacted with thumbs up emoji
roleroz added 2 commits May 28, 2023 21:55 
- Reorder member initialization on BLELocalCharacteristic
- Remove unused variables in:
 - HCIClass::tryResolveAddress
 - HCIClass::handleEventPkt (the whole else if statement did nothing)
 - L2CAPSignalingClass::handleSecurityData (one initialization should be inside of _BLE_TRACE_
 - BluetoothCryptoToolbox::f5
 - BluetoothCryptoToolbox::testAh
 - BluetoothCryptoToolbox::testg2
- Uninitialized variable in L2CAPSignalingClass::handleSecurityData
Copy link

CLAassistant commented May 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 29, 2023
Copy link
Contributor Author

roleroz commented Jun 18, 2023

Friendly ping on this

Copy link
Contributor Author

roleroz commented Jul 16, 2023

How can I get this PR reviewed?
gmacario reacted with eyes emoji

@per1234 per1234 linked an issue Jul 20, 2023 that may be closed by this pull request
10 tasks
@facchinm facchinm merged commit 675fc91 into arduino-libraries:master Aug 4, 2023
Copy link
Contributor

facchinm commented Aug 4, 2023

@roleroz
sorry for the late response but last couple of months have been very intensive 🙂
I reviewed the PR and the fixes looked good (in particular the BLELocalCharacteristic constructor was bothering me every time I compiled 😅 ).
Thanks so much!
gmacario reacted with hooray emoji

Copy link
Contributor Author

roleroz commented Aug 4, 2023

Commented on the issue assigned to this, this PR didn't fix all of it, there is one case left. If you can answer the question I put there (#310 (comment)) I'll gladly create another PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings when compiling this code

AltStyle によって変換されたページ (->オリジナル) /