Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Warnings when compiling this code #310

Closed
Labels
conclusion: resolvedIssue was resolved topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project
@roleroz

Description

When you build the code in this library there are several warnings printed

  • (削除) Order member initialization on BLELocalCharacteristic (削除ここまで) (fixed by Fix warnings #302 )
  • (削除) Unused variables in: (削除ここまで) (fixed by Fix warnings #302 )
    • (削除) HCIClass::tryResolveAddress (削除ここまで)
    • (削除) HCIClass::handleEventPkt (the whole else if statement did nothing) (削除ここまで)
    • (削除) L2CAPSignalingClass::handleSecurityData (one initialization should be inside of BLE_TRACE) (削除ここまで)
    • (削除) BluetoothCryptoToolbox::f5 (削除ここまで)
    • (削除) BluetoothCryptoToolbox::testAh (削除ここまで)
    • (削除) BluetoothCryptoToolbox::testg2 (削除ここまで)
  • (削除) Uninitialized variable in L2CAPSignalingClass::handleSecurityData (削除ここまで) (fixed by Fix warnings #302 )
  • Unenumerated case in ArduinoBLE/src/utility/HCI.cpp (would be fixed by merge of fix(HCI): missing LE_Event_Mask #386 )
(削除) I have a PR ready for fixing most of these warnings (all except the last one) in https://github.com//pull/302, but I haven't had luck getting any traction on getting that reviewed (削除ここまで)

(削除) If someone could review that PR most of these things would be fixed.
(削除ここまで)

If someone tells me what 0x0A means in that unenumerated case, I'm happy to add that to the enum as well

Additional context

Additional reports

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    conclusion: resolvedIssue was resolved topic: codeRelated to content of the project itself type: imperfectionPerceived defect in any part of project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /