-
Notifications
You must be signed in to change notification settings - Fork 517
Conversation
@dongjoon-hyun
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a quick PR, @vrozov .
@williamhyun made a PR to have a test coverage to prevent the same mistake.
Could you rebase this PR to the main branch once more because #2340 is merged now, @vrozov ?
Oh, wait for a while. Please ignore my previous comment. It seems that our CI has some different settings on PR builder and commit builder. I'm digging now.
vrozov
commented
Jul 27, 2025
Ack.
@dongjoon-hyun
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
dongjoon-hyun
commented
Aug 13, 2025
I believe that this will be verified completely by the release manager. If there is any issue, we can revisit this at that time. Thank you, @vrozov .
What changes were proposed in this pull request?
Upgrade to Apache parent pom version 34
Why are the changes needed?
Version 27 is almost 10 years old.
How was this patch tested?
Running maven build (with and without -Papache-release) profile
Was this patch authored or co-authored using generative AI tooling?
No