-
Notifications
You must be signed in to change notification settings - Fork 517
Conversation
vrozov
commented
May 7, 2025
@dongjoon-hyun Please review
dongjoon-hyun
commented
May 8, 2025
Could you make the CI happy, @vrozov ?
vrozov
commented
May 9, 2025
@dongjoon-hyun Is it known that the latest spotbugs reports bugs?
@dongjoon-hyun
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to main for Apache ORC 2.2.0.
Thank you, @vrozov .
dongjoon-hyun
commented
May 10, 2025
Welcome to the Apache ORC community. I added you to the Apache ORC contributor group (of ASF JIRA) and assigned ORC-1891 to you.
williamhyun
commented
Jul 26, 2025
This change seems to break the main and 2.2 branch:
[ERROR] We have duplicated artifacts attached.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache ORC 2.3.0-SNAPSHOT:
[INFO]
[INFO] Apache ORC ......................................... SUCCESS [ 8.028 s]
[INFO] ORC Shims .......................................... FAILURE [ 1.374 s]
[INFO] ORC Core ........................................... SKIPPED
[INFO] ORC MapReduce ...................................... SKIPPED
[INFO] ORC Tools .......................................... SKIPPED
[INFO] ORC Examples ....................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9.477 s
[INFO] Finished at: 2025年07月26日T14:51:02-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.1:jar-no-fork (create-source-jar) on project orc-shims: Presumably you have configured maven-source-plugin to execute twice in your build. You have to configure a classifier for at least one of them. -> [Help 1]
Let me revert this to unblock ORC 2.2 release.
dongjoon-hyun
commented
Jul 26, 2025
Oh, sorry for the trouble. +1 for reverting. Thank you so much, @williamhyun .
vrozov
commented
Jul 26, 2025
@dongjoon-hyun @williamhyun Should be fixed in #2341. The error is caused by apache-release profile defining attach-sources execution id for maven-source-plugin that conflicts with create-source-jar execution id.
dongjoon-hyun
commented
Jul 27, 2025
Thanks. Let see if the fixed PR passed the new CI, @vrozov .
What changes were proposed in this pull request?
Upgrade to Apache parent pom version 34
Why are the changes needed?
Version 27 is almost 10 years old.
How was this patch tested?
Running maven build
Was this patch authored or co-authored using generative AI tooling?
No