-
Notifications
You must be signed in to change notification settings - Fork 517
ORC-1963: Enforce Apache release profile with maven install - #2340
Open
williamhyun wants to merge 3 commits into
Open
ORC-1963: Enforce Apache release profile with maven install #2340williamhyun wants to merge 3 commits into
williamhyun wants to merge 3 commits into
Conversation
williamhyun
marked this pull request as draft
July 26, 2025 22:27
dongjoon-hyun
dongjoon-hyun
previously approved these changes
Jul 27, 2025
@dongjoon-hyun
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Thank you for adding this CI, @williamhyun .
dongjoon-hyun
marked this pull request as ready for review
July 27, 2025 04:16
@dongjoon-hyun
dongjoon-hyun
changed the title
(削除) ORC-XXX: Enforce Apache release profile with maven install (削除ここまで)
(追記) ORC-1963: Enforce Apache release profile with maven install (追記ここまで)
Jul 27, 2025
dongjoon-hyun
commented
Jul 27, 2025
Member
Let me merge this, @williamhyun .
dongjoon-hyun
commented
Jul 27, 2025
Member
Oh my bad. I was too eager to have this coverage.
- The PR builder pass on this PR.
- However, the commit builder seems to fail in the branch.
Since I merged this PR, let me dig this.
dongjoon-hyun
commented
Jul 27, 2025
Member
I realized that publish-snapshot is independent from the PR builder .
dongjoon-hyun
commented
Jul 27, 2025
Member
Let me revert this. Sorry for the trouble, @williamhyun .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What changes were proposed in this pull request?
This PR aims to enforce
apache-releaseprofile with Maven install in CIs.Why are the changes needed?
To detect a release blocker as early as possible.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.