-
Notifications
You must be signed in to change notification settings - Fork 986
DRILL-7169: Rename drill-root ArtifactID to apache-drill #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ba5ab3 to
0bbb212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vdiravka, with this change, a folder with the unpacked build in distribution was renamed from apache-drill-1.16.0-SNAPSHOT to distribution-1.16.0-SNAPSHOT, so for now built version is in the distribution/target/distribution-1.16.0-SNAPSHOT/distribution-1.16.0-SNAPSHOT/ instead of distribution/target/apache-drill-1.16.0-SNAPSHOT/apache-drill-1.16.0-SNAPSHOT/.
I don't think that we should rename these folders.
vdiravka
commented
Apr 12, 2019
@vdiravka, with this change, a folder with the unpacked build in distribution was renamed from
apache-drill-1.16.0-SNAPSHOTtodistribution-1.16.0-SNAPSHOT, so for now built version is in thedistribution/target/distribution-1.16.0-SNAPSHOT/distribution-1.16.0-SNAPSHOT/instead ofdistribution/target/apache-drill-1.16.0-SNAPSHOT/apache-drill-1.16.0-SNAPSHOT/.I don't think that we should rename these folders.
Thanks for finding this, it is random mistake.
distribution/pom.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the <location>target/... can be replaced by <location>${project.build.directory}/....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Done.
pom.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this path correct ? I don't see any src/main/protobuf path ?
Also there are other places like line 549 which can be modified to replace target/classes with ${project.build.outputDirectory}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Looks like it was introduced for a long time ago for
maven-antrun-plugin.
b53933f#diff-0c2b5a9caaab6aa53c1c6c7dead7be77R118
But a little bit later this usage was removed. I think it is safe to remove it. -
Modified
f0652d9 to
21d95d8
Compare
@sohami
sohami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@vvysotskyi
vvysotskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but as we discussed before, it would be good to hear community opinion about this change.
Please send a letter to the dev and user mailing lists about this change.
@vvysotskyi
vvysotskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
- change 'project.artifactId' from 'drill-root' to 'apache-drill'
...hes with ${project.build.directory},
${project.build.outputDirectory} and ${project.build.testOutputDirectory} properties accordingly
21d95d8 to
badd57c
Compare
vdiravka
commented
May 8, 2019
@vvysotskyi @sohami I have rebased the changes onto latest Drill master branch and added one commit with minor improvement.
Please review it, once the community will agreed in dev mailing list with these changes:
Note: mail topic is Rename 'project.artifactId'
arina-ielchiieva
commented
Jun 3, 2019
@vdiravka / @vvysotskyi what is the status of this PR?
vvysotskyi
commented
Jun 3, 2019
Currently, there is no consensus for this change, here is mail thread with the discussion: https://lists.apache.org/thread.html/99a2098ae04d56dd5994288b5fc05780d7de09a2f4a5ffbc5ce39cde@%3Cdev.drill.apache.org%3E
Change 'project.artifactId' from 'drill-root' to 'apache-drill'
Note: it includes changes for #1743 also (it is expected that PR will be merged first)