-
Notifications
You must be signed in to change notification settings - Fork 986
DRILL-7165: Redundant Checksum calculating for ASC files #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vdiravka
commented
Apr 10, 2019
@sohami Couold you please review?
Here is one not mandatory change: drill-root -> apache-drill project artifactId.
It is more convenient to use it as a parameter ${project.artifactId} or ${project.parent.artifactId} instead of hardcoding apache-drill everywhere.
The question is it safe to change Drill project artifactId? Looks like drill-root isn't used by external tools.
Not sure there are other risks to rename it. If they are, please let me know.
sohami
commented
Apr 10, 2019
@vdiravka - I would recommend handling the rename change in separate PR rather than doing now if there is even slight risk of it breaking anything.
- change 'checksum-maven-plugin' 'goal' - 'artifacts' -> 'files' - specify 'includes' in 'fileSet' for 'checksum-maven-plugin'
e913d81 to
f826b78
Compare
vdiravka
commented
Apr 11, 2019
@sohami
sohami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
Uh oh!
There was an error while loading. Please reload this page.