-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/form-field): label not truncated in fill appearance #26353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@crisbeto
crisbeto
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
labels
Jan 3, 2023
@crisbeto
crisbeto
requested review from
devversion and
mmalerba
as code owners
January 3, 2023 08:11
Fixes that the label text wasn't being truncated for form fields with the `fill` appearance, because MDC only sets a `max-width` on outlined form field labels. Fixes angular#26337.
@crisbeto
crisbeto
force-pushed
the
26337/form-field-label-truncate
branch
from
January 3, 2023 10:35
3a99f33
to
474d3f7
Compare
devversion
devversion
approved these changes
Jan 3, 2023
@crisbeto
crisbeto
added
the
action: merge
The PR is ready for merge by the caretaker
label
Jan 3, 2023
@andrewseguin
andrewseguin
assigned
devversion and
amysorto and unassigned
devversion and
amysorto
Jun 5, 2023
@josephperrott
josephperrott
requested review from
amysorto
and removed request for
a team
December 18, 2024 17:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the label text wasn't being truncated for form fields with the
fill
appearance, because MDC only sets amax-width
on outlined form field labels.Fixes #26337.