-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/form-field): update text field styles for better alignment and overflow handling #30716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/form-field): update text field styles for better alignment and overflow handling #30716
Conversation
...nt and overflow handling Fixes angular#28743
I tried something similar in #26353. The problem is that we would have to update the screenshot tests of thousands of internal apps.
I tried something similar in #26353. The problem is that we would have to update the screenshot tests of thousands of internal apps.
Ok, should I revert these changes or try some other way if any ?
There's no way around updating those screenshots. The fact that text truncates differently will cause them to fail.
Then better to close MR
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
Currently,
mat-labeloverlapsmat-suffixin cases foroutlineandfillappearance. This fix set the width to inherit and set the notchmax-widthto same180pxwhich is same asmat-mdc-form-field-infixFixes #28743