-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): resolve PostCSS plugins relative to config file #31119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alan-agius4
alan-agius4
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
target: patch
This PR is targeted for the next patch release
labels
Sep 4, 2025
14 tasks
@alan-agius4
alan-agius4
added
target: patch
This PR is targeted for the next patch release
target: minor
This PR is targeted for the next minor release
and removed
target: patch
This PR is targeted for the next patch release
labels
Sep 4, 2025
clydin
clydin
reviewed
Sep 4, 2025
packages/angular/build/src/tools/esbuild/stylesheets/stylesheet-plugin-factory.ts
Outdated
Show resolved
Hide resolved
@alan-agius4
alan-agius4
force-pushed
the
tailwinds-css
branch
from
September 4, 2025 14:41
4b0118d to
b381df8
Compare
clydin
clydin
approved these changes
Sep 4, 2025
Previously, PostCSS plugins were resolved from the location of `@angular/build`. This caused issues when the PostCSS configuration file was located in a subdirectory and used plugins not hoisted to the root `node_modules`, as plugins would not be found. This change updates the PostCSS configuration loading to resolve plugins relative to the directory containing the PostCSS configuration file. This ensures that plugins are correctly located regardless of the configuration files location.
@alan-agius4
alan-agius4
force-pushed
the
tailwinds-css
branch
from
September 4, 2025 14:43
b381df8 to
aaa6665
Compare
@alan-agius4
alan-agius4
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PostCSS plugins were resolved from the location of
@angular/build. This caused issues when the PostCSS configuration file was located in a subdirectory and used plugins not hoisted to the rootnode_modules, as plugins would not be found.This change updates the PostCSS configuration loading to resolve plugins relative to the directory containing the PostCSS configuration file. This ensures that plugins are correctly located regardless of the configuration files location.