Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit b381df8

Browse files
fix(@angular/build): resolve PostCSS plugins relative to config file
Previously, PostCSS plugins were resolved from the location of `@angular/build`. This caused issues when the PostCSS configuration file was located in a subdirectory and used plugins not hoisted to the root `node_modules`, as plugins would not be found. This change updates the PostCSS configuration loading to resolve plugins relative to the directory containing the PostCSS configuration file. This ensures that plugins are correctly located regardless of the configuration files location.
1 parent bf4f042 commit b381df8

File tree

4 files changed

+22
-13
lines changed

4 files changed

+22
-13
lines changed

‎packages/angular/build/src/tools/esbuild/stylesheets/bundle-options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export interface BundleStylesheetOptions {
3131
externalDependencies?: string[];
3232
target: string[];
3333
tailwindConfiguration?: { file: string; package: string };
34-
postcssConfiguration?: PostcssConfiguration;
34+
postcssConfiguration?: {config: PostcssConfiguration;configPath: string};
3535
publicPath?: string;
3636
cacheOptions: NormalizedCachedOptions;
3737
}

‎packages/angular/build/src/tools/esbuild/stylesheets/stylesheet-plugin-factory.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@
99
import type { OnLoadResult, Plugin, PluginBuild } from 'esbuild';
1010
import assert from 'node:assert';
1111
import { readFile } from 'node:fs/promises';
12-
import { extname } from 'node:path';
12+
import { dirname,extname } from 'node:path';
1313
import type { Options } from 'sass';
1414
import { glob } from 'tinyglobby';
1515
import { assertIsError } from '../../../utils/error';
1616
import type { PostcssConfiguration } from '../../../utils/postcss-configuration';
1717
import { LoadResultCache, createCachedLoad } from '../load-result-cache';
18+
import { createRequire } from 'node:module';
1819

1920
/**
2021
* Configuration options for handling Sass-specific deprecations in a stylesheet plugin.
@@ -69,7 +70,7 @@ export interface StylesheetPluginOptions {
6970
* initialized and used for every stylesheet. This overrides the tailwind integration
7071
* and any tailwind usage must be manually configured in the custom postcss usage.
7172
*/
72-
postcssConfiguration?: PostcssConfiguration;
73+
postcssConfiguration?: {config: PostcssConfiguration;configPath: string};
7374

7475
/**
7576
* Optional Options for configuring Sass behavior.
@@ -215,14 +216,16 @@ export class StylesheetPluginFactory {
215216

216217
const { options } = this;
217218
if (options.postcssConfiguration) {
218-
const postCssInstanceKey = JSON.stringify(options.postcssConfiguration);
219+
const { config, configPath } = options.postcssConfiguration;
220+
const postCssInstanceKey = JSON.stringify(config);
219221
let postcssProcessor = postcssProcessors.get(postCssInstanceKey)?.deref();
220222

221223
if (!postcssProcessor) {
222224
postcss ??= (await import('postcss')).default;
223225
postcssProcessor = postcss();
224-
for (const [pluginName, pluginOptions] of options.postcssConfiguration.plugins) {
225-
const { default: plugin } = await import(pluginName);
226+
const postCssPluginRequire = createRequire(dirname(configPath) + '/');
227+
for (const [pluginName, pluginOptions] of config.plugins) {
228+
const plugin = postCssPluginRequire(pluginName);
226229
if (typeof plugin !== 'function' || plugin.postcss !== true) {
227230
throw new Error(`Attempted to load invalid Postcss plugin: "${pluginName}"`);
228231
}

‎packages/angular/build/src/utils/postcss-configuration.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,13 @@ async function readPostcssConfiguration(
7171
return config;
7272
}
7373

74-
export async function loadPostcssConfiguration(
75-
searchDirectories: SearchDirectory[],
76-
): Promise<PostcssConfiguration | undefined> {
74+
export async function loadPostcssConfiguration(searchDirectories: SearchDirectory[]): Promise<
75+
| {
76+
configPath: string;
77+
config: PostcssConfiguration;
78+
}
79+
| undefined
80+
> {
7781
const configPath = findFile(searchDirectories, postcssConfigurationFiles);
7882
if (!configPath) {
7983
return undefined;
@@ -101,7 +105,7 @@ export async function loadPostcssConfiguration(
101105
}
102106
}
103107

104-
return config;
108+
return {config, configPath };
105109
}
106110

107111
// Normalize plugin object map form
@@ -119,5 +123,5 @@ export async function loadPostcssConfiguration(
119123
config.plugins.push([name, options]);
120124
}
121125

122-
return config;
126+
return {config, configPath };
123127
}

‎packages/angular_devkit/build_angular/src/tools/webpack/configs/styles.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,10 @@ export async function getStylesConfig(wco: WebpackConfigOptions): Promise<Config
8383
const postcssConfig = await loadPostcssConfiguration(searchDirectories);
8484

8585
if (postcssConfig) {
86-
for (const [pluginName, pluginOptions] of postcssConfig.plugins) {
87-
const resolvedPlugin = require.resolve(pluginName, { paths: [root] });
86+
for (const [pluginName, pluginOptions] of postcssConfig.config.plugins) {
87+
const resolvedPlugin = require.resolve(pluginName, {
88+
paths: [path.dirname(postcssConfig.configPath)],
89+
});
8890
const { default: plugin } = await import(resolvedPlugin);
8991
if (typeof plugin !== 'function' || plugin.postcss !== true) {
9092
throw new Error(`Attempted to load invalid Postcss plugin: "${pluginName}"`);

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /