perf(@schematics/angular): optimize AST traversal utilities #31049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

clydin merged 1 commit into angular:main from clydin:ng-schematics/ast-perf

Aug 28, 2025

Merged

perf(@schematics/angular): optimize AST traversal utilities #31049

clydin merged 1 commit into angular:main from clydin:ng-schematics/ast-perf

Aug 28, 2025

+27 −11

Conversation

clydin

Copy link

Member

@clydin clydin commented Aug 26, 2025

Improves the performance of AST utility functions by reducing redundant work and memory allocations.

The findNodes function is now memoized with a WeakMap-based cache. This prevents repeated traversals of the entire source file AST when searching for nodes of the same kind, which is a common pattern.
The getSourceNodes function has been refactored to use a single array instead of two, reducing memory overhead and avoiding costly shift() operations.

@clydin clydin added the target: major label

Aug 26, 2025

@angular-robot angular-robot bot added area: performance area: @schematics/angular labels

Aug 26, 2025

@clydin clydin added the action: review label

Aug 27, 2025

@clydin clydin requested a review from alan-agius4

August 27, 2025 12:24

alan-agius4

alan-agius4 approved these changes

Aug 28, 2025

View reviewed changes

@alan-agius4 alan-agius4 added action: merge target: major and removed action: review target: major labels

Aug 28, 2025

jkrems

jkrems approved these changes

Aug 28, 2025

View reviewed changes

packages/schematics/angular/utility/ast-utils.ts Show resolved Hide resolved

@clydin


 perf(@schematics/angular): optimize AST traversal utilities

3009ebd

Improves the performance of AST utility functions by reducing redundant work and memory allocations.
- The `findNodes` function is now memoized with a `WeakMap`-based cache. This prevents repeated traversals of the entire source file AST when searching for nodes of the same kind, which is a common pattern.
- The `getSourceNodes` function has been refactored to use a single array instead of two, reducing memory overhead and avoiding costly `shift()` operations.