Commit 14c0a9b

committed

perf(@schematics/angular): optimize AST traversal utilities

Improves the performance of AST utility functions by reducing redundant work and memory allocations. - The `findNodes` function is now memoized with a `WeakMap`-based cache. This prevents repeated traversals of the entire source file AST when searching for nodes of the same kind, which is a common pattern. - The `getSourceNodes` function has been refactored to use a single array instead of two, reducing memory overhead and avoiding costly `shift()` operations.

1 parent 0a450ca commit 14c0a9bCopy full SHA for 14c0a9b

File tree

1 file changed

+27

-11

lines changed

packages/schematics/angular/utility
- ast-utils.ts

1 file changed

+27

-11

lines changed

`‎packages/schematics/angular/utility/ast-utils.ts‎`

Lines changed: 27 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,11 @@ export function insertImport(`
`90`	`90`	`);`
`91`	`91`	`}`
`92`	`92`
	`93`	`+const findNodesCache = new WeakMap<`
	`94`	`+ ts.SourceFile,`
	`95`	`+ Map<ts.SyntaxKind \| ((node: ts.Node) => boolean), ts.Node[]>`
	`96`	`+>();`
	`97`	`+`
`93`	`98`	`/**`
`94`	`99`	`* Find all nodes from the AST in the subtree of node of SyntaxKind kind.`
`95`	`100`	`* @param node`
`@@ -137,6 +142,14 @@ export function findNodes<T extends ts.Node>(`
`137`	`142`	`? kindOrGuard`
`138`	`143`	`: (node: ts.Node): node is T => node.kind === kindOrGuard;`
`139`	`144`
	`145`	`+ // Caching is only supported for the entire file`
	`146`	`+ if (ts.isSourceFile(node)) {`
	`147`	`+ const sourceFileCache = findNodesCache.get(node);`
	`148`	`+ if (sourceFileCache?.has(kindOrGuard)) {`
	`149`	`+ return sourceFileCache.get(kindOrGuard) as T[];`
	`150`	`+ }`
	`151`	`+ }`
	`152`	`+`
`140`	`153`	`const arr: T[] = [];`
`141`	`154`	`if (test(node)) {`
`142`	`155`	`arr.push(node);`
`@@ -157,6 +170,15 @@ export function findNodes<T extends ts.Node>(`
`157`	`170`	`}`
`158`	`171`	`}`
`159`	`172`
	`173`	`+ if (ts.isSourceFile(node)) {`
	`174`	`+ let sourceFileCache = findNodesCache.get(node);`
	`175`	`+ if (!sourceFileCache) {`
	`176`	`+ sourceFileCache = new Map();`
	`177`	`+ findNodesCache.set(node, sourceFileCache);`
	`178`	`+ }`
	`179`	`+ sourceFileCache.set(kindOrGuard, arr);`
	`180`	`+ }`
	`181`	`+`
`160`	`182`	`return arr;`
`161`	`183`	`}`
`162`	`184`
`@@ -167,20 +189,14 @@ export function findNodes<T extends ts.Node>(`
`167`	`189`	`*/`
`168`	`190`	`export function getSourceNodes(sourceFile: ts.SourceFile): ts.Node[] {`
`169`	`191`	`const nodes: ts.Node[] = [sourceFile];`
`170`		`- const result: ts.Node[] = [];`
`171`		`-`
`172`		`- while (nodes.length > 0) {`
`173`		`- const node = nodes.shift();`
`174`	`192`
`175`		`- if (node) {`
`176`		`- result.push(node);`
`177`		`- if (node.getChildCount(sourceFile) >= 0) {`
`178`		`- nodes.unshift(...node.getChildren());`
`179`		`- }`
`180`		`- }`
	`193`	`+ // NOTE: nodes.length changes inside of the loop but we only append to the end`
	`194`	`+ for (let i = 0; i < nodes.length; i++) {`
	`195`	`+ const node = nodes[i];`
	`196`	`+ nodes.push(...node.getChildren(sourceFile));`
`181`	`197`	`}`
`182`	`198`
`183`		`- return result;`
	`199`	`+ return nodes;`
`184`	`200`	`}`
`185`	`201`
`186`	`202`	`export function findNode(node: ts.Node, kind: ts.SyntaxKind, text: string): ts.Node \| null {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 14c0a9b

File tree

1 file changed

1 file changed

`‎packages/schematics/angular/utility/ast-utils.ts‎`

0 commit comments