-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular-devkit/build-angular): Downgrade Karma to 5.1.x #19336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update
~5.1.0 as otherwise existing projects will be migrated to 5.2.x, when running ng update @angular/cli
e64418d to
3ac0a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kyliau
There's a bug in Karma 5.2.x that causes unit tests to fail when they should not. It was supposed to be fixed in karma-runner/karma#3565 but CI still failed, blocking the release of Karma. In order to mitigate this, we temporarily downgrade Karma back to 5.1.x A side-effect of this is that coverage tests that uses karma-coverage and exceeds the threshold will not fail, because karma-coverage requires Karma 5.2.x. We expect this to be fixed very soon.
3ac0a1c to
0a32f85
Compare
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
There's a bug in Karma 5.2.x that causes unit tests to fail when they
should not. It was supposed to be fixed in
karma-runner/karma#3565 but CI still failed,
blocking the release of Karma.
In order to mitigate this, we temporarily downgrade Karma back to 5.1.x
A side-effect of this is that coverage tests that uses karma-coverage
and exceeds the threshold will not fail, because karma-coverage requires
Karma 5.2.x. We expect this to be fixed very soon.