Commit 3ac0a1c

author

Keen Yee Liau

committed

fix(@angular-devkit/build-angular): Downgrade Karma to 5.1.x

There's a bug in Karma 5.2.x that causes unit tests to fail when they should not. It was supposed to be fixed in karma-runner/karma#3565 but CI still failed, blocking the release of Karma. In order to mitigate this, we temporarily downgrade Karma back to 5.1.x A side-effect of this is that coverage tests that uses karma-coverage and exceeds the threshold will not fail, because karma-coverage requires Karma 5.2.x. We expect this to be fixed very soon.

1 parent a9175be commit 3ac0a1cCopy full SHA for 3ac0a1c

File tree

3 files changed

-3

lines changed

packages
- angular_devkit/build_angular
  - package.json
  - src/webpack/plugins
    - karma.ts
- schematics/angular/workspace/files
  - package.json.template

3 files changed

-3

lines changed

`‎packages/angular_devkit/build_angular/package.json‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`"@angular-devkit/core": "0.0.0",`
`14`	`14`	`"@babel/core": "7.12.3",`
`15`	`15`	`"@babel/generator": "7.12.1",`
`16`		`- "@babel/plugin-transform-runtime": "7.12.1",`
	`16`	`+ "@babel/plugin-transform-runtime": "7.12.1",`
`17`	`17`	`"@babel/preset-env": "7.12.1",`
`18`	`18`	`"@babel/runtime": "7.12.1",`
`19`	`19`	`"@babel/template": "7.10.4",`
`@@ -80,7 +80,7 @@`
`80`	`80`	`"peerDependencies": {`
`81`	`81`	`"@angular/compiler-cli": "^11.0.0 \|\| ^11.0.0-next",`
`82`	`82`	`"@angular/localize": "^11.0.0 \|\| ^11.0.0-next",`
`83`		`- "karma": "^5.2.0",`
	`83`	`+ "karma": "^5.1.0",`
`84`	`84`	`"ng-packagr": "^11.0.0 \|\| ^11.0.0-next",`
`85`	`85`	`"protractor": "^7.0.0",`
`86`	`86`	`"tslint": "^6.1.0",`

`‎packages/angular_devkit/build_angular/src/webpack/plugins/karma.ts‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ const init: any = (config: any, emitter: any, customFileHandlers: any) => {`
`99`	`99`	`const hasIstanbulReporter = reporters.includes('coverage-istanbul');`
`100`	`100`	`if (hasCoveragePlugin && !hasCoverageReporter) {`
`101`	`101`	`reporters.push('coverage');`
	`102`	+ logger.warn(`There is a known issue with Karma and karma-coverage. Tests that exceed the coverage threshold will not fail. This will be fixed in Karma 5.2.x soon.`)
`102`	`103`	`}`
`103`	`104`	`else if (hasIstanbulPlugin && !hasIstanbulReporter) {`
`104`	`105`	`// coverage-istanbul is deprecated in favor of karma-coverage`

`‎packages/schematics/angular/workspace/files/package.json.template‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`"codelyzer": "^6.0.0",`
`31`	`31`	`"jasmine-core": "~3.6.0",`
`32`	`32`	`"jasmine-spec-reporter": "~5.0.0",`
`33`		`- "karma": "~5.2.0",`
	`33`	`+ "karma": "~5.1.0",`
`34`	`34`	`"karma-chrome-launcher": "~3.1.0",`
`35`	`35`	`"karma-coverage": "~2.0.3",`
`36`	`36`	`"karma-jasmine": "~4.0.0",`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3ac0a1c

File tree

3 files changed

3 files changed

`‎packages/angular_devkit/build_angular/package.json‎`

`‎packages/angular_devkit/build_angular/src/webpack/plugins/karma.ts‎`

`‎packages/schematics/angular/workspace/files/package.json.template‎`

0 commit comments