Skip to content

Navigation Menu

Sign in
Sign up

Custom Theming Support - #224

Open
versx wants to merge 7 commits into
master from
themes
Open

Custom Theming Support #224
versx wants to merge 7 commits into
master from
themes

Conversation

@versx

@versx versx commented Sep 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Better implementation of #218 to allow you to create beautiful and elegant themes like the following:
Omg: (originally named Mygod 😉)

TODO:

  • Remove server side theme option

image

Default:
image

Blue:
image

Dark:
image

Light:
image

Green:
image

@versx versx changed the title (削除) Add custom themes (削除ここまで) (追記) Custom Theming Support (追記ここまで) Sep 24, 2020

@clburlison clburlison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile support 🙂😅

image

versx commented Sep 24, 2020

Copy link
Copy Markdown
Collaborator Author

Mobile support 🙂😅

image

Oof, thanks

@clburlison clburlison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mygod Mygod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now whenever I write a new style I need to write it in five different css.example too or check that they work correctly for all five example themes and pray that it does not break some custom themes? What a terrible idea. No thanks.

versx reacted with laugh emoji

versx commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator Author

So now whenever I write a new style I need to write it in five different css.example too or check that they work correctly for all five example themes and pray that it does not break some custom themes? What a terrible idea. No thanks.

You write it for that one theme...

Mygod commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

As I said you still need to test them all. Not very excited.

@versx versx added the enhancement New feature or request label Sep 27, 2020

versx commented Mar 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Anyone have any suggestions for improving this so @Mygod doesn't have to update each template when there's changes?

Mygod commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

Maybe have some guidelines for contributing, so that everyone knows how to add a UI element that will be consistent with themes?

versx commented Mar 11, 2021

Copy link
Copy Markdown
Collaborator Author

Maybe have some guidelines for contributing, so that everyone knows how to add a UI element that will be consistent with themes?

Thanks, that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mygod Mygod Mygod left review comments
@clburlison clburlison clburlison approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /