Skip to content

Navigation Menu

Sign in
Sign up

Bootswatch Theme API Support - #218

Closed
versx wants to merge 4 commits into
master from
theme-selector
Closed

Bootswatch Theme API Support #218
versx wants to merge 4 commits into
master from
theme-selector

Conversation

@versx

@versx versx commented Sep 19, 2020
edited
Loading

Copy link
Copy Markdown
Collaborator

@TurtIeSocks TurtIeSocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the resizing of the header an anticipated result?

Everything seems to work though, I think putting it somewhere in 'Settings' would be better. Or at the very least to the left of the Clear Cache button. It seems out of place currently.

@Mygod Mygod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some themes:

  • Top right banner buttons are not vertically centered.
  • The top bar also covers the map controls.
  • Pokemon/Pokestop title uses the alternative text style but not Gym title. Also all other text still uses the old style (including font).
  • Font used in filter menu is also inconsistent.
    image
  • Some theme does not differ red buttons and default buttons, e.g. Journal.
    image
  • Dropdown menu has incorrect text color sometimes.
    image

Overall comment: I guess it is cool? Although I think the theme switch should be for server admin only. I do not think adding this feature is worth the maintenance efforts. (just look at number of bugs I found from my light testing)

@clburlison clburlison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions either way... It works. Shetchy is a strong contender for best theme. I do think I'd rather this get hidden under the user settings.

versx commented Sep 24, 2020

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #224

@versx versx closed this Sep 24, 2020
versx deleted the theme-selector branch April 9, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clburlison clburlison clburlison left review comments
@TurtIeSocks TurtIeSocks TurtIeSocks left review comments
@Mygod Mygod Mygod requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /