-
-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
@TurtIeSocks
TurtIeSocks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the resizing of the header an anticipated result?
Everything seems to work though, I think putting it somewhere in 'Settings' would be better. Or at the very least to the left of the Clear Cache button. It seems out of place currently.
@Mygod
Mygod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some themes:
- Top right banner buttons are not vertically centered.
- The top bar also covers the map controls.
- Pokemon/Pokestop title uses the alternative text style but not Gym title. Also all other text still uses the old style (including font).
- Font used in filter menu is also inconsistent.
image - Some theme does not differ red buttons and default buttons, e.g. Journal.
image - Dropdown menu has incorrect text color sometimes.
image
Overall comment: I guess it is cool? Although I think the theme switch should be for server admin only. I do not think adding this feature is worth the maintenance efforts. (just look at number of bugs I found from my light testing)
@clburlison
clburlison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinions either way... It works. Shetchy is a strong contender for best theme. I do think I'd rather this get hidden under the user settings.
versx
commented
Sep 24, 2020
Closing in favor of #224
Uh oh!
There was an error while loading. Please reload this page.
TODO:
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image