-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat: Added speed unit conversion functionality #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have https://github.com/TheAlgorithms/JavaScript/blob/master/Conversions/LengthConversion.js, and I don't really see what this adds in contrast. If anything, you should generalize the "conversion" to take the unit table as a parameter, such that both speed and length conversions would be using the same code.
(Speed units actually consist of two units, though: a length unit divided by a time unit, and the code should ideally reflect that).
We already have https://github.com/TheAlgorithms/JavaScript/blob/master/Conversions/LengthConversion.js, and I don't really see what this adds in contrast. If anything, you should generalize the "conversion" to take the unit table as a parameter, such that both speed and length conversions would be using the same code.
(Speed units actually consist of two units, though: a length unit divided by a time unit, and the code should ideally reflect that).
Got it. Will be sending the unit type as a parameter in the new common conversion.js Thank you.
Uh oh!
There was an error while loading. Please reload this page.
Open in Gitpod know more
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.