-
Notifications
You must be signed in to change notification settings - Fork 214
Don't include do_task() results in the summary (fix #851) - #855
Open
kablamo wants to merge 1 commit into
Open
Conversation
krimdomu
commented
Dec 19, 2015
Contributor
Currently this crashes on my windows system (win 10, perl 5.22.0) (perl interpreter just dies)
The idea to define a parent task is nice and maybe we can extend this idea to print a tree like summary.
Also i'm not sure if we want to hide do_task calls in the summary. The difference between run_task and do_task is that run_task is used to run one task on one server to get some value in return. So the Rexfile should handle failures with this internally.
do_task on the other hand just run the task on all the defined servers so i think it is good to display those results.
krimdomu
commented
Dec 19, 2015
Contributor
I'm going to add this to 1.5.0 milestone, then we can think about it and how we want to display the results.
@ferki
ferki
changed the title
(削除) Don't include do_task() results in the summary (削除ここまで)
(追記) Don't include do_task() results in the summary (fix #851) (追記ここまで)
Apr 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #851
How to test
prove t/summary.t