Skip to content

Navigation Menu

Sign in
Sign up

Refactor Rex::TaskList. No functional change. - #849

Closed
kablamo wants to merge 1 commit into
RexOps:master from
kablamo:refactor-tasklist-run
Closed

Refactor Rex::TaskList. No functional change. #849
kablamo wants to merge 1 commit into
RexOps:master from
kablamo:refactor-tasklist-run

Conversation

@kablamo

@kablamo kablamo commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

I'm trying to clean up the code to make way for new functionality. This pr is purely a refactor and there should be no functional changes introduced. Summary of the changes:

  • Moved $forked_sub out of Rex::TaskList->run() and into its own function.
  • This function is now shared between Rex::TaskList::Base and Rex::TaskList::Parallel_ForkManager.
  • Removed functions from Rex::TaskList::Parallel_Forkmanager which are already in Rex::TaskList::Base.

kablamo commented Dec 4, 2015

Copy link
Copy Markdown
Contributor Author

Ready for review

@ferki ferki added this to the 1.4.0 milestone Dec 9, 2015

ferki commented Dec 9, 2015

Copy link
Copy Markdown
Member

It's a dependency of #851/#855.

Copy link
Copy Markdown
Contributor

Hi @kablamo ,

this is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /