Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Week1 polishes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IdoElk merged 7 commits into master from week1_polishes
Apr 14, 2019
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions week1/1_Strings_and_Output.ipynb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
},
"outputs": [],
"source": [
"print('\"Why were you lurking under our window?\"\"Yes - yes, good point, Petunia! What were you doing under our windows, boy?\"\"Listening to the news,\" said Harry in a resigned voice. His aunt and uncle exchanged looks of outrage. \"Listening to the news! Again?\" \"Well, it changes every day, you see,\" said Harry.')"
"print('\"Listening to the news,\" said Harry in a resigned voice. His aunt and uncle exchanged looks of outrage. \"Listening to the news! Again?\" \"Well, it changes every day, you see,\" said Harry.')"
Copy link
Member

@yammesicka yammesicka Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the long example (and the buildup) adds some value.
Would you please rollback this specific change? All the others are terrific.

]
},
{
Expand Down Expand Up @@ -367,7 +367,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.1"
"version": "3.7.3"
}
},
"nbformat": 4,
Expand Down
4 changes: 2 additions & 2 deletions week1/4_Variables.ipynb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@
"source": [
"<p style=\"text-align: right; direction: rtl; float: right;\">\n",
"קניתי 5 ארגזים גדולים של קרמבו. בארגז יש 10 קרמבו בכל שורה, ו־4 קרמבו בכל עמודה.<br>\n",
"נסו לשים כל אחד מהנתונים שמצאתם בשאלה במשתנה, ולהדפיס את התשובה הנכונה.\n",
"נסו לשים כל אחד מהנתונים שמצאתם בשאלה במשתנה, ולהדפיס כמה קרמבו יש לי.\n",
Copy link
Member

@yammesicka yammesicka Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I usually fix myself when talking in general instead of mentioning specifics, but it's hard to find it all.

"</p>"
]
},
Expand Down Expand Up @@ -463,7 +463,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.1"
"version": "3.7.3"
}
},
"nbformat": 4,
Expand Down
6 changes: 3 additions & 3 deletions week1/5_Input_and_Casting.ipynb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@
"moshe_apples = input(\"How many apples does Moshe have? \")\n",
"moshe_apples = int(moshe_apples) # <--- Casting\n",
"moshe_apples = moshe_apples + 1\n",
"print(\"Moshe have \" + moshe_apples + \" apples\")"
"print(\"Moshe has \" + moshe_apples + \" apples\")"
]
},
{
Expand All @@ -471,7 +471,7 @@
"moshe_apples = int(moshe_apples) # <--- Casting to int\n",
"moshe_apples = moshe_apples + 1\n",
"moshe_apples = str(moshe_apples) # <--- Casting to str\n",
"print(\"Moshe have \" + moshe_apples + \" apples\")"
"print(\"Moshe has \" + moshe_apples + \" apples\")"
]
},
{
Expand Down Expand Up @@ -581,7 +581,7 @@
"מסטיק בזוקה קובע שעד גיל 21 תגיעו לירח. אנחנו פחות אופטימיים (לנו פשוט זה פחות עבד), ומנבאים לך הצלחה עד גיל 90.<br>\n",
"כתוב תוכנה שמקבלת כקלט את השם שלך ואת הגיל שלך, ומחשבת עוד כמה שנים תגיע לירח לפי הנבואה שלנו.<br>\n",
"התוכנה תדפיס את המשפט: <q dir=\"ltr\">X, wait another Y years.</q>, כאשר X יוחלף בשמך ו־Y יוחלף במספר השנים שתצטרך לחכות עד גיל 90.<br>\n",
"<em>לדוגמה</em>: אם הכנסתך לתכנה שגילך הוא 25, התכנה תדפיס:\n",
"<em>לדוגמה</em>: אם הכנסתך לתכנה שגילך הוא 25 ושמך הוא ים, התכנה תדפיס:\n",
"</p>"
]
},
Expand Down
21 changes: 19 additions & 2 deletions week1/6_Booleans.ipynb
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,23 @@
"</p>"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"<div class=\"align-center\" style=\"display: flex; text-align: right; direction: rtl;\">\n",
" <div style=\"display: flex; width: 10%; float: right; \">\n",
" <img src=\"images/warning.png\" style=\"height: 50px !important;\" alt=\"אזהרה!\"> \n",
" </div>\n",
" <div style=\"width: 90%\">\n",
" <p style=\"text-align: right; direction: rtl;\">\n",
" טעות נפוצה בעת שימוש בערכים בוליאנים היא לא להתחשב ברגישות לאותיות גדולות/קטנות.<br>\n",
" לדוגמה: <code>True</code> יהיה תקין בעוד <code>true</code> יקפיץ שגיאה.\n",
" </p>\n",
" </div>\n",
"</div>"
]
},
{
"cell_type": "markdown",
"metadata": {},
Expand Down Expand Up @@ -611,7 +628,7 @@
"metadata": {},
"source": [
"<p style=\"text-align: right; direction: rtl; float: right;\">\n",
"במחוז בולילנד השערורייתי, מותר לאכול פיצה רק מכיל 25 ומעלה.<br>\n",
"במחוז בולילנד השערורייתי, מותר לאכול פיצה רק מגיל 25 ומעלה.<br>\n",
"קבלו כקלט את גילו של המשתמש. הדפיסו לו <samp>True</samp> במידה והוא יכול לאכול פיצה בבולילנד, או <samp>False</samp> אם הוא לא יכול.<br>\n",
"<em>לדוגמה:</em> אם דוד הזין שגילו הוא 23, עליכם להציג לו <samp>False</samp>.\n",
"</p>"
Expand Down Expand Up @@ -657,7 +674,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.1"
"version": "3.7.3"
}
},
"nbformat": 4,
Expand Down

AltStyle によって変換されたページ (->オリジナル) /