Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Week1 polishes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IdoElk merged 7 commits into master from week1_polishes
Apr 14, 2019
Merged

Week1 polishes #11

IdoElk merged 7 commits into master from week1_polishes
Apr 14, 2019

Conversation

Copy link
Contributor

@IdoElk IdoElk commented Apr 14, 2019

Mostly minor typo / word changes.

@IdoElk IdoElk requested a review from yammesicka April 14, 2019 22:21
@@ -352,7 +352,7 @@
"source": [
"<p style=\"text-align: right; direction: rtl; float: right;\">\n",
"קניתי 5 ארגזים גדולים של קרמבו. בארגז יש 10 קרמבו בכל שורה, ו־4 קרמבו בכל עמודה.<br>\n",
"נסו לשים כל אחד מהנתונים שמצאתם בשאלה במשתנה, ולהדפיס את התשובה הנכונה.\n",
"נסו לשים כל אחד מהנתונים שמצאתם בשאלה במשתנה, ולהדפיס כמה קרמבו יש לי.\n",
Copy link
Member

@yammesicka yammesicka Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I usually fix myself when talking in general instead of mentioning specifics, but it's hard to find it all.

@@ -213,7 +213,7 @@
},
"outputs": [],
"source": [
"print('\"Why were you lurking under our window?\" \"Yes - yes, good point, Petunia! What were you doing under our windows, boy?\" \"Listening to the news,\" said Harry in a resigned voice. His aunt and uncle exchanged looks of outrage. \"Listening to the news! Again?\" \"Well, it changes every day, you see,\" said Harry.')"
"print('\"Listening to the news,\" said Harry in a resigned voice. His aunt and uncle exchanged looks of outrage. \"Listening to the news! Again?\" \"Well, it changes every day, you see,\" said Harry.')"
Copy link
Member

@yammesicka yammesicka Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the long example (and the buildup) adds some value.
Would you please rollback this specific change? All the others are terrific.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks.

@IdoElk IdoElk merged commit 48d1d8e into master Apr 14, 2019
@yammesicka yammesicka deleted the week1_polishes branch April 21, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammesicka yammesicka yammesicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /