-
Notifications
You must be signed in to change notification settings - Fork 432
add type for pool.acquire() #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eirnym
commented
Jan 10, 2020
Looks good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type hint only covers usual await case:
con = await pool.acquire()
But won't work properly for context manager case:
async with pool.acquire() as con: await con.execute(...)
The more correct return type could be something like PoolAcquireContext but we should check if mypy understands it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#577 contains more precise types
It is clear that this is incorrect and should be PoolAcquireContext.
I'd suggest either changing that in this PR or just closing this and wait until a PR that targets more of these simple methods is created.
This is superseded by #1209
No description provided.