-
-
Notifications
You must be signed in to change notification settings - Fork 74
Add support for CROSS APPLY and OUTER APPLY generation #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CROSS APPLY and OUTER APPLY generation #1238
Conversation
bb97998 to
b5d272a
Compare
Implement `VisitCrossApply` and `VisitOuterApply` methods to translate CROSS APPLY and OUTER APPLY constructs for Firebird using lateral joins. Adapted logic from Npgsql EF Core provider.
b5d272a to
d7af605
Compare
There's a lot of tests that result in CROSS APPLY/OUTER APPLY that are ignored now, these need to be enabled. You can start by searching for NotSupportedOnFirebirdFact/NotSupportedOnFirebirdTheory.
- Extension method resolution changed causing the wrong Reverse method to be used, casting it to Enumerable resolves this.
There's a lot of tests that result in
CROSS APPLY/OUTER APPLYthat are ignored now, these need to be enabled. You can start by searching forNotSupportedOnFirebirdFact/NotSupportedOnFirebirdTheory.
Just making sure, I'm going through all disabled tests at the moment, and if I spot things which are marked as unsupported by efcore, but which are supported now, should those be enabled too?
if I spot things which are marked as unsupported by efcore, but which are supported now, should those be enabled too?
Yes. But create separate PR.
4b38935 to
05b6a29
Compare
05b6a29 to
c1acf51
Compare
0c30e81 to
a1b7428
Compare
a1b7428 to
02a6dca
Compare
Shamelessly copied from the postgres sql provider, that's why I added the copyright notice above it, no need to reinvent the wheel as they already solved it.
Implement
VisitCrossApplyandVisitOuterApplymethods to translate CROSS APPLY and OUTER APPLY constructs for Firebird using lateral joins. Adapted logic from Npgsql EF Core provider.Related to issue #1165