Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 0c30e81

Browse files
Re-enable tests not supported before due to CROSS JOIN and OUTER APPLY usage.
1 parent 201fa33 commit 0c30e81

File tree

4 files changed

+12
-26
lines changed

4 files changed

+12
-26
lines changed

‎src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindJoinQueryFbTest.cs‎

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,21 @@ public NorthwindJoinQueryFbTest(NorthwindQueryFbFixture<NoopModelCustomizer> fix
2929
: base(fixture)
3030
{ }
3131

32-
[NotSupportedOnFirebirdTheory]
32+
[Theory]
3333
[MemberData(nameof(IsAsyncData))]
3434
public override Task GroupJoin_as_final_operator(bool async)
3535
{
3636
return base.GroupJoin_as_final_operator(async);
3737
}
3838

39-
[NotSupportedOnFirebirdTheory]
39+
[Theory]
4040
[MemberData(nameof(IsAsyncData))]
4141
public override Task GroupJoin_SelectMany_subquery_with_filter_orderby(bool async)
4242
{
4343
return base.GroupJoin_SelectMany_subquery_with_filter_orderby(async);
4444
}
4545

46-
[NotSupportedOnFirebirdTheory]
46+
[Theory]
4747
[MemberData(nameof(IsAsyncData))]
4848
public override Task GroupJoin_SelectMany_subquery_with_filter_orderby_and_DefaultIfEmpty(bool async)
4949
{
@@ -57,13 +57,6 @@ public override Task SelectMany_with_client_eval(bool async)
5757
return base.SelectMany_with_client_eval(async);
5858
}
5959

60-
[NotSupportedOnFirebirdTheory]
61-
[MemberData(nameof(IsAsyncData))]
62-
public override Task SelectMany_with_client_eval_with_collection_shaper(bool async)
63-
{
64-
return base.SelectMany_with_client_eval_with_collection_shaper(async);
65-
}
66-
6760
[NotSupportedOnFirebirdTheory]
6861
[MemberData(nameof(IsAsyncData))]
6962
public override Task SelectMany_with_client_eval_with_collection_shaper_ignored(bool async)
@@ -78,13 +71,6 @@ public override Task SelectMany_with_selecting_outer_element(bool async)
7871
return base.SelectMany_with_selecting_outer_element(async);
7972
}
8073

81-
[NotSupportedOnFirebirdTheory]
82-
[MemberData(nameof(IsAsyncData))]
83-
public override Task SelectMany_with_selecting_outer_entity(bool async)
84-
{
85-
return base.SelectMany_with_selecting_outer_entity(async);
86-
}
87-
8874
[NotSupportedOnFirebirdTheory]
8975
[MemberData(nameof(IsAsyncData))]
9076
public override Task SelectMany_with_selecting_outer_entity_column_and_inner_column(bool async)
@@ -99,14 +85,14 @@ public override Task Take_in_collection_projection_with_FirstOrDefault_on_top_le
9985
return base.Take_in_collection_projection_with_FirstOrDefault_on_top_level(async);
10086
}
10187

102-
[NotSupportedOnFirebirdTheory]
88+
[Theory]
10389
[MemberData(nameof(IsAsyncData))]
10490
public override Task Unflattened_GroupJoin_composed(bool async)
10591
{
10692
return base.Unflattened_GroupJoin_composed(async);
10793
}
10894

109-
[NotSupportedOnFirebirdTheory]
95+
[Theory]
11096
[MemberData(nameof(IsAsyncData))]
11197
public override Task Unflattened_GroupJoin_composed_2(bool async)
11298
{

‎src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/TPCManyToManyNoTrackingQueryFbTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,21 @@ public TPCManyToManyNoTrackingQueryFbTest(TPCManyToManyQueryFbFixture fixture)
2828
: base(fixture)
2929
{ }
3030

31-
[NotSupportedOnFirebirdTheory]
31+
[Theory]
3232
[MemberData(nameof(IsAsyncData))]
3333
public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(bool async)
3434
{
3535
return base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async);
3636
}
3737

38-
[NotSupportedOnFirebirdTheory]
38+
[Theory]
3939
[MemberData(nameof(IsAsyncData))]
4040
public override Task Skip_navigation_order_by_single_or_default(bool async)
4141
{
4242
return base.Skip_navigation_order_by_single_or_default(async);
4343
}
4444

45-
[NotSupportedOnFirebirdTheory]
45+
[Theory]
4646
[MemberData(nameof(IsAsyncData))]
4747
public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where_EF_Property(bool async)
4848
{

‎src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/TPTGearsOfWarQueryFbTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public override Task Group_by_on_StartsWith_with_null_parameter_as_argument(bool
5555
return base.Group_by_on_StartsWith_with_null_parameter_as_argument(async);
5656
}
5757

58-
[NotSupportedOnFirebirdTheory]
58+
[Theory]
5959
[MemberData(nameof(IsAsyncData))]
6060
public override Task Correlated_collections_inner_subquery_predicate_references_outer_qsre(bool async)
6161
{
@@ -251,14 +251,14 @@ public override Task Array_access_on_byte_array(bool async)
251251
return base.Array_access_on_byte_array(async);
252252
}
253253

254-
[NotSupportedOnFirebirdTheory]
254+
[Theory]
255255
[MemberData(nameof(IsAsyncData))]
256256
public override Task Correlated_collection_after_distinct_3_levels(bool async)
257257
{
258258
return base.Correlated_collection_after_distinct_3_levels(async);
259259
}
260260

261-
[NotSupportedOnFirebirdTheory]
261+
[Theory]
262262
[MemberData(nameof(IsAsyncData))]
263263
public override Task Correlated_collection_via_SelectMany_with_Distinct_missing_indentifying_columns_in_projection(bool async)
264264
{

‎src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/UdfDbFunctionFbTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public override void Udf_with_argument_being_comparison_of_nullable_columns()
5151
base.Udf_with_argument_being_comparison_of_nullable_columns();
5252
}
5353

54-
[NotSupportedOnFirebirdFact]
54+
[Fact]
5555
public override void QF_Select_Correlated_Subquery_In_Anonymous_MultipleCollections()
5656
{
5757
base.QF_Select_Correlated_Subquery_In_Anonymous_MultipleCollections();

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /