-
-
Notifications
You must be signed in to change notification settings - Fork 35
Allow removal of platform instance for testing purposes #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 1.0.1 | ||
|
|
||
| * Adds `removeInstance` to `GoogleApiAvailabilityPlatform` for testing purposes. | ||
|
|
||
| ## 1.0.0 | ||
|
|
||
| * Extracts the common platform interface from the google_api_availability package. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import 'package:flutter/foundation.dart'; | ||
| import 'package:google_api_availability_platform_interface/google_api_availability_platform_interface.dart'; | ||
| import 'package:plugin_platform_interface/plugin_platform_interface.dart'; | ||
|
|
||
|
|
@@ -33,6 +34,13 @@ abstract class GoogleApiAvailabilityPlatform extends PlatformInterface { | |
| _instance = instance; | ||
| } | ||
|
|
||
| /// Removes the registered instance of the [GoogleApiAvailabilityPlatform] class. | ||
| /// | ||
| /// This method is exposed for testing purposes only and should not be used by | ||
| /// clients of the plugin. | ||
| @visibleForTesting | ||
| static removeInstance() => _instance = null; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a specific use case for this? I have not seen it in any of the other plugins and from the top of my head I cannot really think of a specific case where this is needed. Would like to hear if there is one. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is included so we can test whether the methods that are exposed to users of the plugin correctly throw if no platform is registered. This way we can emulate the scenario where the app runs on an unsupported platform. |
||
|
|
||
| /// Returns the connection status of Google Play Service. | ||
| /// | ||
| /// Optionally, you can also show an error dialog if the connection status is | ||
|
|
||