-
-
Notifications
You must be signed in to change notification settings - Fork 35
Allow removal of platform instance for testing purposes #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@paulppn
paulppn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific use case for this?
I have not seen it in any of the other plugins and from the top of my head I cannot really think of a specific case where this is needed. Would like to hear if there is one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is included so we can test whether the methods that are exposed to users of the plugin correctly throw if no platform is registered. This way we can emulate the scenario where the app runs on an unsupported platform.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Adds method to platform interface to remove the registered instance. This is useful for tests where a test needs to check the behavior of a non-existing instance.
There is no way to set the instance to null, as there is a specific check to prevent users from doing that.
🆕 What is the new behavior (if this is a feature change)?
Using
removeInstance, tests can unregistered a previously registered instance of the platform interface.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
This PR is part of #33.
🤔 Checklist before submitting