2
4
Fork
You've already forked ethereal
10

WIP: Migrate corals and seaweed to plantlike_rooted #5

Closed
Niklp wants to merge 1 commit from Niklp/ethereal:master into master
pull from: Niklp/ethereal:master
merge into: tenplus1:master
tenplus1:master
First-time contributor
Copy link

This is a WIP pull for getting feedback.

This PR will remove the air bubbles around corals and seaweed (TBD) in water.
Requires mte 5.3 due to use of minetest.is_creative_enabled (but I can replace this to keep 5.0 support....)

Changes:

  • Add *_rooted variant of all corals
  • Add logic to decide wether to place the old plantlike or the new plantlike_rooted node
  • Add LBM to migrate already placed & generated notes

TBD:

  • Add rooted variant of seaweed
This is a WIP pull for getting feedback. This PR will remove the air bubbles around corals and seaweed (TBD) in water. Requires mte 5.3 due to use of `minetest.is_creative_enabled` (but I can replace this to keep 5.0 support....) Changes: - Add `*_rooted` variant of all corals - Add logic to decide wether to place the old `plantlike` or the new `plantlike_rooted` node - Add LBM to migrate already placed & generated notes TBD: - Add rooted variant of seaweed

Coral has been updated with some minor fixes, many thanks :)

Coral has been updated with some minor fixes, many thanks :)
tenplus1 closed this pull request 2024年01月22日 09:25:00 +01:00
Author
First-time contributor
Copy link

This was a WIP with bugs... It could make sense if you would wait until I undraft it. 😕

Edit: now I have to rebase my PR on your changes, many thanks..

This was a WIP with bugs... It could make sense if you would wait until I undraft it. 😕 Edit: now I have to rebase my PR on your changes, many thanks..

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tenplus1/ethereal!5
Reference in a new issue
tenplus1/ethereal
No description provided.
Delete branch "Niklp/ethereal:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?