2
4
Fork
You've already forked ethereal
10

Migrate seaweed to plantlike_rooted #6

Closed
Niklp wants to merge 1 commit from Niklp/ethereal:seaweed into master
pull from: Niklp/ethereal:seaweed
merge into: tenplus1:master
tenplus1:master
First-time contributor
Copy link

Second part of #5

Changes:

  • Add rooted variant of seaweed
  • Add migration path for seaweed
  • Add logic to decide wether to place the old plantlike or the new plantlike_rooted node
  • Fix coral update LBM
  • Some other improvements on corals

Friendly reminder to my last PR:
Merging/copying PRs which are marked as "WIP, DO NOT MERGE" and have "TBDs" is absolutely idiotic. In this case, you've merged a not (yet) working LBM which could potentially breaks many worlds.

Second part of https://codeberg.org/tenplus1/ethereal/pulls/5 Changes: - Add `rooted` variant of seaweed - Add migration path for seaweed - Add logic to decide wether to place the old plantlike or the new plantlike_rooted node - **Fix coral update LBM** - Some other improvements on corals Friendly reminder to my last PR: Merging/copying PRs which are marked as "WIP, DO NOT MERGE" and have "TBDs" is absolutely idiotic. In this case, you've merged a not (yet) working LBM which could potentially breaks many worlds.

Added with changes:

  • On digging seaweed it returns number of items per height
  • Abm checks for seaweed_rooted and helps it grow
  • On placing seaweed it starts at 1 high

Many thanks for your addition :)

Added with changes: - On digging seaweed it returns number of items per height - Abm checks for seaweed_rooted and helps it grow - On placing seaweed it starts at 1 high Many thanks for your addition :)
tenplus1 closed this pull request 2024年01月23日 09:43:29 +01:00
Author
First-time contributor
Copy link

@tenplus1 You forgot some of my changes, the coral migration is definitely broken.

@tenplus1 You forgot some of my changes, the coral migration is definitely broken.

Changes added, working ok it seems.

Changes added, working ok it seems.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tenplus1/ethereal!6
Reference in a new issue
tenplus1/ethereal
No description provided.
Delete branch "Niklp/ethereal:seaweed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?