Add flash messages if no alert email is set #19

edwardloveall commented 2025年08月19日 22:11:39 +02:00

Fixes #15

Picture a recurring event where future events have a volunteer but an earlier one does not. Adding that same volunteer to the earlier shift and all future shifts creates a "conflict" that we warn organizations about. That email is sent to the organization's internal_alerts_email.

If they don't have an email in that field, we would crash!! Instead of that, we put a message reminding them to fill out that email, and continue on successfully.

please add alert

Technically this works by returning a result object from the mutating EventsService methods (except delete ones). Before this, if a problem happens inside the EventService, we didn't have a great
way of dealing with it outside that service. update, update_into_future, and post_occurrence_details all now return an EventResult which contains an event and flash messages (sometimes empty). The controller can then still access the event, but also let the user know about other problems (or celebrations).

I didn't add them to the delete methods because nothing actually expected any events to be returned from them.

I also enabled mailer errors in development because they were off and it took me a while to figure out how to reproduce the bug.

Fixes #15 Picture a recurring event where future events have a volunteer but an earlier one does not. Adding that same volunteer to the earlier shift and all future shifts creates a "conflict" that we warn organizations about. That email is sent to the organization's `internal_alerts_email`. If they don't have an email in that field, we would crash!! Instead of that, we put a message reminding them to fill out that email, and continue on successfully.  Technically this works by returning a result object from the mutating `EventsService` methods (except delete ones). Before this, if a problem happens inside the `EventService`, we didn't have a great way of dealing with it outside that service. `update`, `update_into_future`, and `post_occurrence_details` all now return an `EventResult` which contains an event and flash messages (sometimes empty). The controller can then still access the `event`, but also let the user know about other problems (or celebrations). I didn't add them to the delete methods because nothing actually expected any events to be returned from them. I also enabled mailer errors in development because they were off and it took me a while to figure out how to reproduce the bug.

thetizzo commented 2025年08月20日 21:39:55 +02:00

Side note: I had a thought about the 2 task_logs_controllers that I'm not sure is worth the effort unless you find yourself needing to modify how those work in a significant way. But they are almost identical so I would be tempted to try and combine them into a single controller.

Side note: I had a thought about the 2 `task_logs_controller`s that I'm not sure is worth the effort unless you find yourself needing to modify how those work in a significant way. But they are almost identical so I would be tempted to try and combine them into a single controller.

edwardloveall commented 2025年08月20日 22:02:54 +02:00

@thetizzo wrote in #19 (comment):

Side note: I had a thought about the 2 task_logs_controllers that I'm not sure is worth the effort unless you find yourself needing to modify how those work in a significant way. But they are almost identical so I would be tempted to try and combine them into a single controller.

Oh yeah, huh. I could probably do some responds_to magic as long as the auth works the same for both.

@thetizzo wrote in https://codeberg.org/rootable/tomato/pulls/19#issuecomment-6614950: > Side note: I had a thought about the 2 `task_logs_controller`s that I'm not sure is worth the effort unless you find yourself needing to modify how those work in a significant way. But they are almost identical so I would be tempted to try and combine them into a single controller. Oh yeah, huh. I could probably do some `responds_to` magic as long as the auth works the same for both.

edwardloveall commented 2025年08月20日 22:39:15 +02:00

Spec is flaky. Watched it pass locally.

Spec is flaky. Watched it pass locally.