Archived
10
18
Fork
You've already forked newroma
3

Elixir 1.13 fixes #8

Merged
floatingghost merged 2 commits from bugfix/elixir-1.13 into develop 2022年01月29日 14:11:41 +01:00
Contributor
Copy link

Has been tested against both 1.12 and 1.13.

Depends-on: #5
Closes: #2

Has been tested against both 1.12 and 1.13. Depends-on: https://codeberg.org/newroma-dev/newroma/pulls/5 Closes: https://codeberg.org/newroma-dev/newroma/issues/2
Add link headers in ChatController.index2
See merge request pleroma/pleroma!3562 
Fix replies count for remote replies
See merge request pleroma/pleroma!3541 
Add "exposable_reactions" to features, if showing reactions
See merge request pleroma/pleroma!3523 
Add initial Nodeinfo document
See merge request pleroma/pleroma!3546 
Handle Reject for already-accepted Follows properly
Closes #2766 and #2802
See merge request pleroma/pleroma!3568 
MastoAPI: accept notify param in follow request
See merge request pleroma/pleroma!3555 
MastoAPI: Add user notes on accounts
See merge request pleroma/pleroma!3540 
Elixir 1.13 does not allow them in raw form anymore, resulting in errors
like this when running the test:
== Compilation error in file test/pleroma/web/rich_media/parser_test.exs ==
** (SyntaxError) test/pleroma/web/rich_media/parser_test.exs:136:45: invalid bidirectional formatting character in string: \u202C. If you want to use such character, use it in its escaped \u202C form instead
Moving it to "warning" would break tests on 1.12.x
Member
Copy link

I confirm it works with Elixir 1.13

Finished in 294.5 seconds (85.7s async, 208.8s sync)
3567 tests, 0 failures, 2 excluded, 4 skipped
Randomized with seed 591719
ilja@kubuntu-laptop:~/development/fedi/newroma/newroma$ elixir --version
Erlang/OTP 24 [erts-12.2] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1]
Elixir 1.13.0 (compiled with Erlang/OTP 24)

This also means #3 and #2 can be closed.

I confirm it works with Elixir 1.13 ``` Finished in 294.5 seconds (85.7s async, 208.8s sync) 3567 tests, 0 failures, 2 excluded, 4 skipped Randomized with seed 591719 ilja@kubuntu-laptop:~/development/fedi/newroma/newroma$ elixir --version Erlang/OTP 24 [erts-12.2] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] Elixir 1.13.0 (compiled with Erlang/OTP 24) ``` This also means https://codeberg.org/newroma-dev/newroma/pulls/3 and https://codeberg.org/newroma-dev/newroma/issues/2 can be closed.
lanodan force-pushed bugfix/elixir-1.13 from dba7a4a187 to a4b8a1150e 2022年01月25日 14:48:42 +01:00 Compare
floatingghost left a comment

tested on CI against 1.12 and 1.13, works

tested on CI against 1.12 and 1.13, works
Commenting is not possible because the repository is archived.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
newroma-dev/newroma!8
Reference in a new issue
newroma-dev/newroma
No description provided.
Delete branch "bugfix/elixir-1.13"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?