Archived
10
18
Fork
You've already forked newroma
3

bugfix: logs use warning instead of warn #3

Closed
floatingghost wants to merge 1 commit from bugfix/log-format-tests into develop
pull from: bugfix/log-format-tests
merge into: newroma-dev:develop
newroma-dev:develop
newroma-dev:feature/display-name
newroma-dev:weird-entities
newroma-dev:style/fix-credo-warnings
newroma-dev:issue-templates
newroma-dev:feature/woodpecker-integration
newroma-dev:feature/drone-integration
newroma-dev:bugfix/elixir-1.13
newroma-dev:features/cherry-pick-merge
newroma-dev:bugfix/mime-validation-no-list
newroma-dev:copyright-2022

this is quite a small one, the log assertions were testing against warn, which was causing pattern matching in the tests to fail

this is quite a small one, the log assertions were testing against `warn`, which was causing pattern matching in the tests to fail
floatingghost force-pushed bugfix/log-format-tests from 6b70686864 to 3c998711ee 2022年01月24日 16:59:02 +01:00 Compare
Contributor
Copy link

Note: Check if it's related to elixir versions (and so would need more flexible tests to support old versions, 1.9 is oldest supported) or just a dependency update.

Note: Check if it's related to elixir versions (and so would need more flexible tests to support old versions, 1.9 is oldest supported) or just a dependency update.
Member
Copy link

(削除) I just ran the test on this branch and from the 6 failures I saw in #2, there's still the first left (test get_user_apps/1 (Pleroma.Web.OAuth.AppTest)). (削除ここまで)

(削除) But that one isn't related to the warnings, so maybe could go in a separate MR. (削除ここまで)

Elixir version:

$ elixir --version
Erlang/OTP 24 [erts-12.2] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1]
Elixir 1.13.0 (compiled with Erlang/OTP 24)

Edit: This was still from before the force push, so maybe it's fixed with that already.

~~I just ran the test on this branch and from the 6 failures I saw in https://codeberg.org/newroma-dev/newroma/issues/2, there's still the first left (`test get_user_apps/1 (Pleroma.Web.OAuth.AppTest)`).~~ ~~But that one isn't related to the warnings, so maybe could go in a separate MR.~~ Elixir version: ```sh $ elixir --version Erlang/OTP 24 [erts-12.2] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] Elixir 1.13.0 (compiled with Erlang/OTP 24) ``` **Edit:** This was still from before the force push, so maybe it's fixed with that already.
Contributor
Copy link

Note: Check if it's related to elixir versions (and so would need more flexible tests to support old versions, 1.9 is oldest supported) or just a dependency update.

It is version-dependent, will address it in one big MR with compatibility on at least 1.12.x and 1.13.x, could test with more.

> Note: Check if it's related to elixir versions (and so would need more flexible tests to support old versions, 1.9 is oldest supported) or just a dependency update. It is version-dependent, will address it in one big MR with compatibility on at least 1.12.x and 1.13.x, could test with more.
Contributor
Copy link

MR in question: #8

MR in question: https://codeberg.org/newroma-dev/newroma/pulls/8
lanodan closed this pull request 2022年01月25日 14:45:30 +01:00
Commenting is not possible because the repository is archived.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
newroma-dev/newroma!3
Reference in a new issue
newroma-dev/newroma
No description provided.
Delete branch "bugfix/log-format-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?