jsentity pushed to master at jsentity/zig 2026年01月26日 16:59:57 +01:00
337daa816f update comment for .success
jsentity commented on pull request ziglang/zig#30877 2026年01月26日 16:54:45 +01:00
Fix BootServices.locateHandleLen()

alright should be good to go now

jsentity pushed to master at jsentity/zig 2026年01月26日 16:53:54 +01:00
218ad5f0b5 update NumHandlesError
jsentity pushed to master at jsentity/zig 2026年01月26日 16:52:39 +01:00
4291cfd562 let .success and .invalid_parametercascade into else/unexpected branch and add comments explaining why
jsentity pushed to master at jsentity/zig 2026年01月26日 16:50:44 +01:00
acd427ee32 Merge remote-tracking branch 'upstream/master'
b4c86c850d Fix std.uefi.protocol.DevicePath.next() and add utility function isEnd() (#30887)
Compare 2 commits »
jsentity pushed to master at jsentity/zig 2026年01月26日 16:46:12 +01:00
d1ba05e998 re-add branch for .success
c295b59b77 re enable invalid_parameter and update NumHandlesError
722ab41245 Let unreachable blocks cascade into else statement
7b2e9693ad Fix BootServices.locateHandleLen()
Compare 5 commits »
jsentity commented on pull request ziglang/zig#30877 2026年01月26日 15:50:11 +01:00
Fix BootServices.locateHandleLen()

Should the same happen to .success or do we leave it as is?

jsentity commented on pull request ziglang/zig#30877 2026年01月26日 15:49:40 +01:00
Fix BootServices.locateHandleLen()

okay so then .invalid_parameter cascades into else and the branch is commented out, explaining why it is considered unreachable/unexpected.

jsentity commented on pull request ziglang/zig#30877 2026年01月26日 15:05:16 +01:00
Fix BootServices.locateHandleLen()

Personally, I think unreachable is better suited for situations where your code can guarantee an invariant internally. In this case, and for (std.posix), the invariant depends on an external...

jsentity commented on pull request ziglang/zig#30877 2026年01月26日 14:28:17 +01:00
Fix BootServices.locateHandleLen()

in !30877 (commit 72f1996084) I also handled invalid_parameter with unreachable, but later removed it, since I wasn't sure if the...

jsentity pushed to master at jsentity/zig 2026年01月26日 11:04:37 +01:00
b43f62182d re-add branch for .success
8ee3ba3ded re enable invalid_parameter and update NumHandlesError
c935351280 Let unreachable blocks cascade into else statement
72f1996084 Fix BootServices.locateHandleLen()
f186809caf
 std: impl process.totalSystemMemory for netbsd
Compare 64 commits »
jsentity commented on pull request ziglang/zig#30877 2026年01月26日 11:03:35 +01:00
Fix BootServices.locateHandleLen()

alright, added the changes. Would it also make sense to create narrower errors for invalid_parameter, since most cases (if not all, currently) are unreachable?

jsentity pushed to master at jsentity/zig 2026年01月26日 10:55:59 +01:00
d1ba05e998 re-add branch for .success
jsentity pushed to uefi_device_path_next_fix at jsentity/zig 2026年01月25日 21:41:49 +01:00
2b77decc00 Merge branch 'master' into uefi_device_path_next_fix
8709f53d44 crypto.ff: allow seamless chaining regardless of representation (#30913)
99ec1ee353
 ci: temporarily disable x86_64-netbsd while I investigate failures
a2ea36a517 zig libc: modify errno helper to eliminate @intCast
9d63dfaa81
 link.Lld: give better exit status information for the lld child process
Compare 50 commits »
jsentity pushed to uefi_device_path_next_fix at jsentity/zig 2026年01月25日 21:41:19 +01:00
d410e9b6b2 inline isEnd in next() and remove isEnd
jsentity commented on pull request ziglang/zig#30887 2026年01月25日 21:38:57 +01:00
Fix std.uefi.protocol.DevicePath.next() and add utility function isEnd()

Fair enough, and I do agree, just wanted offered my reason for implementing it that way

jsentity commented on pull request ziglang/zig#30887 2026年01月25日 04:58:14 +01:00
Fix std.uefi.protocol.DevicePath.next() and add utility function isEnd()

I used EDK II as reference when implementing and just rolled with their api:

jsentity created pull request ziglang/zig#30887 2026年01月19日 09:16:08 +01:00
Fix std.uefi.protocol.DevicePath.next() and add utility function isEnd()
jsentity pushed to uefi_device_path_next_fix at jsentity/zig 2026年01月19日 09:12:58 +01:00
4e1451e005 Fix std.uefi.protocol.DevicePath.next() and add utility function isEnd
4e99f095ae
 ci: avoid github.run_id in concurrency.group
27e8d05ee8 Fix protocol.DevicePath.next() (#30883)
d2dda0737b std.Io.Threaded: sendmmsg can return EACCES
4cc3e1c05e Merge pull request 'libc: use common implementations for string.h and strings.h' (#30872) from GasInfinity/zig:libc-string(s) into master
Compare 5 commits »
jsentity created branch uefi_device_path_next_fix in jsentity/zig 2026年01月19日 09:12:58 +01:00