ziglang/zig
262
5.9k
Fork
You've already forked zig
759

Fix BootServices.locateHandleLen() #30877

Merged
alexrp merged 13 commits from jsentity/zig:master into master 2026年01月27日 23:09:58 +01:00
Contributor
Copy link

Fix for #30876

Fix for https://codeberg.org/ziglang/zig/issues/30876
Fix BootServices.locateHandleLen()
Some checks are pending
ci / aarch64-linux-debug (pull_request) Blocked by required conditions
ci / aarch64-linux-release (pull_request) Blocked by required conditions
ci / aarch64-macos-debug (pull_request) Blocked by required conditions
ci / aarch64-macos-release (pull_request) Blocked by required conditions
ci / loongarch64-linux-debug (pull_request) Blocked by required conditions
ci / loongarch64-linux-release (pull_request) Blocked by required conditions
ci / powerpc64le-linux-debug (pull_request) Blocked by required conditions
ci / powerpc64le-linux-release (pull_request) Blocked by required conditions
ci / riscv64-linux-debug (pull_request) Blocked by required conditions
ci / riscv64-linux-release (pull_request) Blocked by required conditions
ci / s390x-linux-debug (pull_request) Blocked by required conditions
ci / s390x-linux-release (pull_request) Blocked by required conditions
ci / x86_64-freebsd-debug (pull_request) Blocked by required conditions
ci / x86_64-freebsd-release (pull_request) Blocked by required conditions
ci / x86_64-linux-debug (pull_request) Blocked by required conditions
ci / x86_64-linux-debug-llvm (pull_request) Blocked by required conditions
ci / x86_64-linux-release (pull_request) Blocked by required conditions
ci / x86_64-openbsd-debug (pull_request) Blocked by required conditions
ci / x86_64-openbsd-release (pull_request) Blocked by required conditions
ci / x86_64-windows-debug (pull_request) Blocked by required conditions
ci / x86_64-windows-release (pull_request) Blocked by required conditions
7b2e9693ad
Let unreachable blocks cascade into else statement
Some checks failed
ci / x86_64-freebsd-release (pull_request) Successful in 36m12s
ci / x86_64-openbsd-release (pull_request) Failing after 1h51m8s
ci / x86_64-freebsd-debug (pull_request) Failing after 1h51m46s
ci / x86_64-windows-release (pull_request) Failing after 1h51m53s
ci / x86_64-windows-debug (pull_request) Failing after 1h51m55s
ci / x86_64-linux-debug (pull_request) Failing after 1h57m24s
ci / x86_64-openbsd-debug (pull_request) Failing after 2h2m6s
ci / aarch64-linux-debug (pull_request) Successful in 2h12m54s
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Successful in 2h24m2s
ci / loongarch64-linux-release (pull_request) Successful in 2h25m0s
ci / aarch64-linux-release (pull_request) Failing after 2h26m38s
ci / loongarch64-linux-debug (pull_request) Failing after 2h29m53s
ci / s390x-linux-debug (pull_request) Successful in 2h30m54s
ci / powerpc64le-linux-release (pull_request) Failing after 2h37m4s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 2h37m11s
ci / s390x-linux-release (pull_request) Failing after 2h45m25s
ci / aarch64-macos-debug (pull_request) Successful in 1h33m53s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h43m9s
722ab41245
re enable invalid_parameter and update NumHandlesError
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 37m17s
ci / x86_64-windows-debug (pull_request) Successful in 38m11s
ci / x86_64-openbsd-release (pull_request) Successful in 43m5s
ci / x86_64-windows-release (pull_request) Successful in 44m21s
ci / x86_64-freebsd-debug (pull_request) Successful in 44m47s
ci / x86_64-openbsd-debug (pull_request) Successful in 58m46s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 28m37s
ci / aarch64-linux-release (pull_request) Successful in 1h27m36s
ci / powerpc64le-linux-release (pull_request) Successful in 1h44m57s
ci / s390x-linux-release (pull_request) Successful in 1h44m58s
ci / aarch64-linux-debug (pull_request) Successful in 2h13m5s
ci / aarch64-macos-debug (pull_request) Successful in 1h21m36s
ci / s390x-linux-debug (pull_request) Successful in 2h23m24s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h32m14s
ci / x86_64-linux-release (pull_request) Successful in 2h46m29s
ci / loongarch64-linux-debug (pull_request) Successful in 3h16m25s
ci / loongarch64-linux-release (pull_request) Successful in 2h28m33s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h40m54s
ci / x86_64-linux-debug (pull_request) Successful in 1h5m44s
c295b59b77
@ -702,8 +702,9 @@ pub const BootServices = extern struct {
&len,
null,
)){
.success=>return@divExact(len,@sizeOf(Handle)),
Member
Copy link

I'd prefer to keep an explicit switch prong handling .success with unreachable and a comment explaining why.

I'd prefer to keep an explicit switch prong handling `.success` with `unreachable` and a comment explaining why.
Author
Contributor
Copy link

alright, added the changes. Would it also make sense to create narrower errors for invalid_parameter, since most cases (if not all, currently) are unreachable?

alright, added the changes. Would it also make sense to create narrower errors for invalid_parameter, since most cases (if not all, currently) are unreachable?
Member
Copy link

Indeed,. according to the spec EFI_INVALID_PARAMETER only occurs when NoHandles or Buffer are null - which they aren't.

Indeed,. according to the spec `EFI_INVALID_PARAMETER` only occurs when `NoHandles` or `Buffer` are null - which they aren't.
Author
Contributor
Copy link

in !30877 (commit 72f1996084) I also handled invalid_parameter with unreachable, but later removed it, since I wasn't sure if the spec could add more reasons in the future for returning that error, in which case, it could become reachable

in https://codeberg.org/ziglang/zig/pulls/30877/commits/72f1996084af401364773d0862d49190b538d9c2 I also handled invalid_parameter with unreachable, but later removed it, since I wasn't sure if the spec could add more reasons in the future for returning that error, in which case, it could become reachable
Member
Copy link

I think for std.posix (or its replacements now that it's getting dissolved) we're also using unreachable for kernel return codes liberally, it can be updated for a new version if needed.

I think for std.posix (or its replacements now that it's getting dissolved) we're also using unreachable for kernel return codes liberally, it can be updated for a new version if needed.
Author
Contributor
Copy link

Personally, I think unreachable is better suited for situations where your code can guarantee an invariant internally. In this case, and for (std.posix), the invariant depends on an external factor that can change at any time. Therefore, I believe error.Unexpected is more appropriate in this case, since existing code using older Zig releases in ReleaseFast/ReleaseSmall could reach UB if the external factor changes. So all zig projects reliant on BootServices.locateHandleLen() would need the newest version, otherwise a patch for every older release would be required, unless every project not using the newest version would essentially be left unsupported and wouldn't be able to rely on the std for avoiding UB. The same issue happened to me recently in 0.15.2 with posix.read (https://github.com/ziglang/zig/issues/25344), where I was forced to create a custom implementation for it, since I was unable to catch the error during debug builds, and would invite UB during unchecked releases if I relied on the std for the functionality.

Personally, I think unreachable is better suited for situations where your code can guarantee an invariant internally. In this case, and for (std.posix), the invariant depends on an external factor that can change at any time. Therefore, I believe error.Unexpected is more appropriate in this case, since existing code using older Zig releases in ReleaseFast/ReleaseSmall could reach UB if the external factor changes. So all zig projects reliant on BootServices.locateHandleLen() would need the newest version, otherwise a patch for every older release would be required, unless every project not using the newest version would essentially be left unsupported and wouldn't be able to rely on the std for avoiding UB. The same issue happened to me recently in 0.15.2 with posix.read (https://github.com/ziglang/zig/issues/25344), where I was forced to create a custom implementation for it, since I was unable to catch the error during debug builds, and would invite UB during unchecked releases if I relied on the std for the functionality.
Member
Copy link

Okay, let's fold it into the else prong then given that it's not an expected error.

Okay, let's fold it into the `else` prong then given that it's not an expected error.
Author
Contributor
Copy link

okay so then .invalid_parameter cascades into else and the branch is commented out, explaining why it is considered unreachable/unexpected.

okay so then `.invalid_parameter` cascades into `else` and the branch is commented out, explaining why it is considered unreachable/unexpected.
Author
Contributor
Copy link

Should the same happen to .success or do we leave it as is?

Should the same happen to `.success` or do we leave it as is?
Member
Copy link

I suppose the same should happen to .success, yes. I'll also have to retract the std.posix argument given https://github.com/ziglang/zig/issues/6389 is accepted.

I suppose the same should happen to `.success`, yes. I'll also have to retract the std.posix argument given https://github.com/ziglang/zig/issues/6389 is accepted.
linus marked this conversation as resolved
re-add branch for .success
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
d1ba05e998
jsentity force-pushed master from d1ba05e998
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
to b43f62182d
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-freebsd-release (pull_request) Successful in 31m30s
ci / aarch64-macos-release (pull_request) Successful in 34m12s
ci / x86_64-windows-debug (pull_request) Successful in 38m39s
ci / x86_64-freebsd-debug (pull_request) Successful in 39m4s
ci / x86_64-openbsd-release (pull_request) Successful in 41m32s
ci / x86_64-windows-release (pull_request) Successful in 42m33s
ci / aarch64-macos-debug (pull_request) Successful in 43m34s
ci / x86_64-openbsd-debug (pull_request) Successful in 49m53s
ci / x86_64-linux-debug (pull_request) Successful in 50m56s
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
2026年01月26日 11:04:35 +01:00 Compare
linus approved these changes 2026年01月26日 11:39:18 +01:00
Dismissed
linus left a comment
Copy link

Thanks!

Thanks!
linus scheduled this pull request to auto merge when all checks succeed 2026年01月26日 11:39:44 +01:00
linus canceled auto merging this pull request when all checks succeed 2026年01月26日 12:24:47 +01:00
Member
Copy link

(cancelled auto-merge as per above discussion)

(cancelled auto-merge as per above discussion)
Fix BootServices.locateHandleLen()
Some checks are pending
ci / aarch64-linux-debug (pull_request) Blocked by required conditions
ci / aarch64-linux-release (pull_request) Blocked by required conditions
ci / aarch64-macos-debug (pull_request) Blocked by required conditions
ci / aarch64-macos-release (pull_request) Blocked by required conditions
ci / loongarch64-linux-debug (pull_request) Blocked by required conditions
ci / loongarch64-linux-release (pull_request) Blocked by required conditions
ci / powerpc64le-linux-debug (pull_request) Blocked by required conditions
ci / powerpc64le-linux-release (pull_request) Blocked by required conditions
ci / riscv64-linux-debug (pull_request) Blocked by required conditions
ci / riscv64-linux-release (pull_request) Blocked by required conditions
ci / s390x-linux-debug (pull_request) Blocked by required conditions
ci / s390x-linux-release (pull_request) Blocked by required conditions
ci / x86_64-freebsd-debug (pull_request) Blocked by required conditions
ci / x86_64-freebsd-release (pull_request) Blocked by required conditions
ci / x86_64-linux-debug (pull_request) Blocked by required conditions
ci / x86_64-linux-debug-llvm (pull_request) Blocked by required conditions
ci / x86_64-linux-release (pull_request) Blocked by required conditions
ci / x86_64-openbsd-debug (pull_request) Blocked by required conditions
ci / x86_64-openbsd-release (pull_request) Blocked by required conditions
ci / x86_64-windows-debug (pull_request) Blocked by required conditions
ci / x86_64-windows-release (pull_request) Blocked by required conditions
7b2e9693ad
Let unreachable blocks cascade into else statement
Some checks failed
ci / x86_64-freebsd-release (pull_request) Successful in 36m12s
ci / x86_64-openbsd-release (pull_request) Failing after 1h51m8s
ci / x86_64-freebsd-debug (pull_request) Failing after 1h51m46s
ci / x86_64-windows-release (pull_request) Failing after 1h51m53s
ci / x86_64-windows-debug (pull_request) Failing after 1h51m55s
ci / x86_64-linux-debug (pull_request) Failing after 1h57m24s
ci / x86_64-openbsd-debug (pull_request) Failing after 2h2m6s
ci / aarch64-linux-debug (pull_request) Successful in 2h12m54s
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Successful in 2h24m2s
ci / loongarch64-linux-release (pull_request) Successful in 2h25m0s
ci / aarch64-linux-release (pull_request) Failing after 2h26m38s
ci / loongarch64-linux-debug (pull_request) Failing after 2h29m53s
ci / s390x-linux-debug (pull_request) Successful in 2h30m54s
ci / powerpc64le-linux-release (pull_request) Failing after 2h37m4s
ci / x86_64-linux-debug-llvm (pull_request) Failing after 2h37m11s
ci / s390x-linux-release (pull_request) Failing after 2h45m25s
ci / aarch64-macos-debug (pull_request) Successful in 1h33m53s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h43m9s
722ab41245
re enable invalid_parameter and update NumHandlesError
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 37m17s
ci / x86_64-windows-debug (pull_request) Successful in 38m11s
ci / x86_64-openbsd-release (pull_request) Successful in 43m5s
ci / x86_64-windows-release (pull_request) Successful in 44m21s
ci / x86_64-freebsd-debug (pull_request) Successful in 44m47s
ci / x86_64-openbsd-debug (pull_request) Successful in 58m46s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 28m37s
ci / aarch64-linux-release (pull_request) Successful in 1h27m36s
ci / powerpc64le-linux-release (pull_request) Successful in 1h44m57s
ci / s390x-linux-release (pull_request) Successful in 1h44m58s
ci / aarch64-linux-debug (pull_request) Successful in 2h13m5s
ci / aarch64-macos-debug (pull_request) Successful in 1h21m36s
ci / s390x-linux-debug (pull_request) Successful in 2h23m24s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h32m14s
ci / x86_64-linux-release (pull_request) Successful in 2h46m29s
ci / loongarch64-linux-debug (pull_request) Successful in 3h16m25s
ci / loongarch64-linux-release (pull_request) Successful in 2h28m33s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h40m54s
ci / x86_64-linux-debug (pull_request) Successful in 1h5m44s
c295b59b77
re-add branch for .success
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
d1ba05e998
Merge branch 'master' of https://codeberg.org/jsentity/zig
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
2c586a5a2c
Merge remote-tracking branch 'upstream/master'
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
acd427ee32
let .success and .invalid_parametercascade into else/unexpected branch and add comments explaining why
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
4291cfd562
update NumHandlesError
Some checks failed
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-macos-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-macos-release (pull_request) Has been cancelled
ci / x86_64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / x86_64-linux-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
218ad5f0b5
Author
Contributor
Copy link

alright should be good to go now

alright should be good to go now
update comment for .success
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-freebsd-release (pull_request) Successful in 32m0s
ci / aarch64-macos-release (pull_request) Successful in 32m30s
ci / x86_64-freebsd-debug (pull_request) Successful in 39m7s
ci / x86_64-windows-release (pull_request) Successful in 40m27s
ci / x86_64-windows-debug (pull_request) Successful in 41m30s
ci / x86_64-openbsd-release (pull_request) Successful in 41m49s
ci / aarch64-macos-debug (pull_request) Successful in 44m45s
ci / x86_64-openbsd-debug (pull_request) Successful in 49m45s
ci / x86_64-linux-debug (pull_request) Successful in 1h6m46s
ci / powerpc64le-linux-release (pull_request) Successful in 1h23m34s
ci / aarch64-linux-release (pull_request) Successful in 1h26m41s
ci / s390x-linux-release (pull_request) Successful in 1h42m10s
ci / loongarch64-linux-release (pull_request) Successful in 1h51m3s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 1h51m48s
ci / aarch64-linux-debug (pull_request) Successful in 2h16m4s
ci / s390x-linux-debug (pull_request) Successful in 3h38m23s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h23m54s
ci / x86_64-linux-release (pull_request) Successful in 2h16m41s
ci / loongarch64-linux-debug (pull_request) Successful in 3h18m58s
337daa816f
linus scheduled this pull request to auto merge when all checks succeed 2026年01月26日 17:21:22 +01:00
alexrp canceled auto merging this pull request when all checks succeed 2026年01月27日 23:09:31 +01:00
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-freebsd-release (pull_request) Successful in 32m0s
ci / aarch64-macos-release (pull_request) Successful in 32m30s
ci / x86_64-freebsd-debug (pull_request) Successful in 39m7s
ci / x86_64-windows-release (pull_request) Successful in 40m27s
ci / x86_64-windows-debug (pull_request) Successful in 41m30s
ci / x86_64-openbsd-release (pull_request) Successful in 41m49s
ci / aarch64-macos-debug (pull_request) Successful in 44m45s
ci / x86_64-openbsd-debug (pull_request) Successful in 49m45s
ci / x86_64-linux-debug (pull_request) Successful in 1h6m46s
ci / powerpc64le-linux-release (pull_request) Successful in 1h23m34s
ci / aarch64-linux-release (pull_request) Successful in 1h26m41s
ci / s390x-linux-release (pull_request) Successful in 1h42m10s
ci / loongarch64-linux-release (pull_request) Successful in 1h51m3s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 1h51m48s
ci / aarch64-linux-debug (pull_request) Successful in 2h16m4s
ci / s390x-linux-debug (pull_request) Successful in 3h38m23s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h23m54s
ci / x86_64-linux-release (pull_request) Successful in 2h16m41s
ci / loongarch64-linux-debug (pull_request) Successful in 3h18m58s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!30877
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "jsentity/zig:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?