13
295
Fork
You've already forked yambar
74

module_mpris: MPRIS client discovery on startup #451

Open
haruInDisguise wants to merge 8 commits from haruInDisguise/yambar:module_mpris_client_sync_on_startup into master
pull from: haruInDisguise/yambar:module_mpris_client_sync_on_startup
merge into: dnkl:master
dnkl:master
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Contributor
Copy link

Until now, the module could only register/manage clients, that were launch when yambar was already running.
This PR resolves this issue by adding "existing client discovery" on startup.

Closes #447

Until now, the module could only register/manage clients, that were launch when yambar was already running. This PR resolves this issue by adding "existing client discovery" on startup. Closes #447
This PR allows us to register pre-existing clients and treat
them just like clients that are created after yambar/this module
launches.
By default, the last discovered client will be displayed.
Non existing clients are now handled correctly.
module_mpris: Cleanup
Some checks reported errors
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job failed
c2ba93aa4f
module_mpris: Removed incorrect/redundant include
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
b7a7bc7db2
module_mpris: Fixed bus name handeling
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
33df540200 
The 'HandleNameChanged' event will no longer attempt to change the
name of non MPRIS clients.
module/mpris: Addressed inconsistent/wrong mutex usage
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
4685e4cf29 
The Module did not (properly) use the modules mutex lock, potentially
enabling data corruption.
Contributor
Copy link

Looks reasonable to me. I'll look at pulling this into maybar.

Looks reasonable to me. I'll look at pulling this into [`maybar`](https://codeberg.org/mathstuf/maybar).
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u module_mpris_client_sync_on_startup:haruInDisguise-module_mpris_client_sync_on_startup
git switch haruInDisguise-module_mpris_client_sync_on_startup

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff haruInDisguise-module_mpris_client_sync_on_startup
git switch haruInDisguise-module_mpris_client_sync_on_startup
git rebase master
git switch master
git merge --ff-only haruInDisguise-module_mpris_client_sync_on_startup
git switch haruInDisguise-module_mpris_client_sync_on_startup
git rebase master
git switch master
git merge --no-ff haruInDisguise-module_mpris_client_sync_on_startup
git switch master
git merge --squash haruInDisguise-module_mpris_client_sync_on_startup
git switch master
git merge --ff-only haruInDisguise-module_mpris_client_sync_on_startup
git switch master
git merge haruInDisguise-module_mpris_client_sync_on_startup
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/yambar!451
Reference in a new issue
dnkl/yambar
No description provided.
Delete branch "haruInDisguise/yambar:module_mpris_client_sync_on_startup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?