mpris module don't update when dbus client is already launched before launching yambar #447

apheleia commented 2025年03月09日 23:54:21 +01:00

If mpv is launched and I launch yambar, pausing/unpausing don't update mpris module.

Launching mpv when yambar is already launched works fine (see video)

If mpv is launched and I launch yambar, pausing/unpausing don't update mpris module. Launching mpv when yambar is already launched works fine (see video)

dnkl commented 2025年03月10日 08:04:08 +01:00

@haruInDisguise

@haruInDisguise

haruInDisguise commented 2025年03月10日 10:15:45 +01:00

This was actually an intentional decision. The mpris module only listens for events on the message bus (like new clients or property changes), and since clients are only advertised on startup, pre-existing clients are not recognized.
The rationale behind this was my assumption, that it is somewhat unlikely for users to start yambar after there mpris client (since yambar probably starts with there WM). But it looks like you have just proven me wrong.

I will see if I can get around to this (削除) today (削除ここまで) week, since this change isn't really straight forward, and will require quite a bit of additional logic.

This was actually an intentional decision. The mpris module only listens for events on the message bus (like new clients or property changes), and since clients are only advertised on startup, pre-existing clients are not recognized. The rationale behind this was my assumption, that it is somewhat unlikely for users to start yambar after there mpris client (since yambar probably starts with there WM). But it looks like you have just proven me wrong. I will see if I can get around to this ~~today~~ week, since this change isn't really straight forward, and will require quite a bit of additional logic.

apheleia commented 2025年03月10日 12:22:09 +01:00

I tought about that. The usecase is that I sometimes use a keybind to "toggle the bar" but there is no way to do this without killing it and relaunching it afterwards.

I know waybar can be toggled with a specific signal (something like kill -s USR1 waybar I forgot the exact cmd). Idk if it can be done with yambar.

I tought about that. The usecase is that I sometimes use a keybind to "toggle the bar" but there is no way to do this without killing it and relaunching it afterwards. I know waybar can be toggled with a specific signal (something like kill -s USR1 waybar I forgot the exact cmd). Idk if it can be done with yambar.

haruInDisguise commented 2025年03月19日 20:59:54 +01:00

@apheleia, I've finally gotten around to implementing client discovery on startup: https://codeberg.org/haruInDisguise/yambar/src/branch/module_mpris_client_sync_on_startup

@dnkl, I'm a bit uncertain about how to commit this feature. Should be its own PR or just another commit in #446? The commit history on this PR is already a bit of a mess, since I just rebranded it into a bugfix "collection" of all the things I messed up.

Edit: typo

@apheleia, I've finally gotten around to implementing client discovery on startup: https://codeberg.org/haruInDisguise/yambar/src/branch/module_mpris_client_sync_on_startup @dnkl, I'm a bit uncertain about how to commit this feature. Should be its own PR or just another commit in #446? The commit history on this PR is already a bit of a mess, since I just rebranded it into a bugfix "collection" of all the things I messed up. Edit: typo

apheleia commented 2025年03月19日 23:56:34 +01:00

it works :D

it works :D

haruInDisguise commented 2025年03月20日 00:27:43 +01:00

Just a heads-up: I've fixed a segfault if there are no clients on startup, and the metadata for existing clients is now processed correctly.

Just a heads-up: I've fixed a segfault if there are no clients on startup, and the metadata for existing clients is now processed correctly.

dnkl commented 2025年03月20日 09:00:58 +01:00

Since #446 has been merged, please open a new PR :)

Since #446 has been merged, please open a new PR :)