added settings & links to gtk documentation #29

Quantenzitrone commented 2023年03月10日 01:37:37 +01:00 (Migrated from github.com)

• all added settings are tested and working
• links are to gtk4 documentation, since it is the newest

I will test and add more later, you can merge now or wait.

see #28

- all added settings are tested and working - links are to gtk4 documentation, since it is the newest I will test and add more later, you can merge now or wait. see #28

derat commented 2023年03月10日 01:42:51 +01:00 (Migrated from github.com)

Thanks! Would you mind keeping the settings sorted within the table? (I think the Gtk/ ones might just need to be moved back to the beginning.)

Thanks! Would you mind keeping the settings sorted within the table? (I think the `Gtk/` ones might just need to be moved back to the beginning.)

Quantenzitrone commented 2023年03月10日 01:44:32 +01:00 (Migrated from github.com)

Oh, I thought moving the Gtk/ down would be a good idea, since the Net/ settings are more standardized, but sure.

Edit: Oh yeah, obviously alphabetic order.

Oh, I thought moving the `Gtk/` down would be a good idea, since the `Net/` settings are more standardized, but sure. Edit: Oh yeah, obviously alphabetic order.

derat commented 2023年03月10日 01:57:49 +01:00 (Migrated from github.com)

Thanks, I think I just have one comment.

Thanks, I think I just have one comment.

derat commented 2023年03月10日 01:59:45 +01:00 (Migrated from github.com)

... which I really wish I could send you, but GitHub is being its usually uncooperative self and just shows it as stuck in a "Pending" state. In case it never actually sends it to you, here it is (in reference to boolean on L124):

please keep this (and other types) as integer rather than boolean. this is referring to the underlying XSETTINGS type, and there's no boolean type, only integers: https://specifications.freedesktop.org/xsettings-spec/0.5/ar01s04.html

... which I really wish I could send you, but GitHub is being its usually uncooperative self and just shows it as stuck in a "Pending" state. In case it never actually sends it to you, here it is (in reference to `boolean` on L124): > please keep this (and other types) as integer rather than boolean. this is referring to the underlying XSETTINGS type, and there's no boolean type, only integers: https://specifications.freedesktop.org/xsettings-spec/0.5/ar01s04.html

Quantenzitrone commented 2023年03月10日 02:02:23 +01:00 (Migrated from github.com)

ok that makes sense

ok that makes sense

derat commented 2023年03月10日 02:56:59 +01:00 (Migrated from github.com)

I've squashed and merged the PR. Thanks again!

I've squashed and merged the PR. Thanks again!