11
31
Fork
You've already forked silverfish
19

#150: Add a musl release #183

Merged
SpencerFabricant merged 6 commits from SpencerFabricant/sfab_silverfish:add_musl into main 2025年12月18日 21:44:10 +01:00

Modified:
ci-aarch64.yml: This will now run on pull requests to main. Added commented out step for later to run tests, but will require specialized hardware
on-release-tag.yml: Added x86_64 musl build

Added:
ci-musl-x86.yml

an aarch64 musl version will require specialized equipment to build.

Example runs:
aarch64: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/1/jobs/0/attempt/1
musl-x86: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/1/jobs/0/attempt/1
amd64: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/3/jobs/0/attempt/1
release tag: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/4/jobs/0/attempt/1
release: https://codeberg.org/SpencerFabricant/sfab_silverfish/releases/tag/v0.1

Modified: _ci-aarch64.yml_: This will now run on pull requests to `main`. Added commented out step for later to run tests, but will require specialized hardware _on-release-tag.yml_: Added x86_64 musl build Added: _ci-musl-x86.yml_ an aarch64 musl version will require specialized equipment to build. Example runs: aarch64: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/1/jobs/0/attempt/1 musl-x86: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/1/jobs/0/attempt/1 amd64: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/3/jobs/0/attempt/1 release tag: https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/4/jobs/0/attempt/1 release: https://codeberg.org/SpencerFabricant/sfab_silverfish/releases/tag/v0.1
updated silverfish--musl-x86_64 name
All checks were successful
aarch64 checks / silverfish--aarch64 (pull_request) Successful in 2m51s
CI Silverfish musl / silverfish--musl-x86_64 (pull_request) Successful in 4m21s
CI Silverfish / silverfish-amd64 (pull_request) Successful in 16m34s
c893e65c91
SpencerFabricant changed title from (削除) #150: Add support for a musl release (削除ここまで) to #150: Add a musl release 2025年12月17日 01:02:05 +01:00
Merge remote-tracking branch 'origin' into add_musl
All checks were successful
aarch64 checks / silverfish--aarch64 (pull_request) Successful in 2m33s
CI Silverfish musl / silverfish--musl-x86_64 (pull_request) Successful in 3m50s
CI Silverfish / silverfish-amd64 (pull_request) Successful in 10m5s
4dac64356d

i'm in the process of testing this right now, will submit review soon!

i'm in the process of testing this right now, will submit review soon!
cjdesno requested changes 2025年12月18日 04:33:34 +01:00
Dismissed
cjdesno left a comment
Copy link

one small ask, otherwise looks good! (though i am still in-progress with testing the release job changes)

one small ask, otherwise looks good! (though i am still in-progress with testing the release job changes)
@ -61,0 +72,4 @@
- name:Build Production amd64 musl
run:cargo build --release --target x86_64-unknown-linux-musl
# NOTE: aarch64 builds on musl may require specialized equipment and are currently disabled
Owner
Copy link

It does make sense to me to leave this note here, but could you please remove all the new commented-out lines for aarch64-musl from this file?

It does make sense to me to leave this note here, but could you please remove all the new commented-out lines for aarch64-musl from this file?
Owner
Copy link

actually i don't think we need to keep this note, either

actually i don't think we need to keep this note, either
SpencerFabricant marked this conversation as resolved

testing all checked out ok

testing all checked out ok
Updated per feedback: Removed commented-out references to aarch64-musl
All checks were successful
aarch64 checks / silverfish--aarch64 (pull_request) Successful in 4m10s
CI Silverfish musl / silverfish--musl-x86_64 (pull_request) Successful in 4m24s
CI Silverfish / silverfish-amd64 (pull_request) Successful in 23m47s
ba2c91ad0c
Author
Owner
Copy link

All set @cjdesno

All set @cjdesno
Author
Owner
Copy link

Moving the extra build steps to Justfile to better keep everything in one place

Moving the extra build steps to `Justfile` to better keep everything in one place
Migrated new build commands to Justfile
All checks were successful
aarch64 checks / silverfish--aarch64 (pull_request) Successful in 2m36s
CI Silverfish / silverfish-amd64 (pull_request) Successful in 2m41s
CI Silverfish musl / silverfish--musl-x86_64 (pull_request) Successful in 24m30s
b59e56f05d
Author
Owner
Copy link

https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/9/jobs/0/attempt/1
This build needs to pass before we merge

https://codeberg.org/SpencerFabricant/sfab_silverfish/actions/runs/9/jobs/0/attempt/1 This build needs to pass before we merge
cjdesno left a comment
Copy link

looks good! we can merge once CI finishes

looks good! we can merge once CI finishes
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat
Breaking
 Breaking change that won't be backward compatible
Flag/Good First Issue
Good issue for first-time contributors
Kind/Accessibility
Accessibility issue, bug or otherwise
Kind/Appearance
Design, styling, and other aesthetic and visual items
Kind/Bug
Something is not working
Kind/Compliance
Legal, policy, or some other kind of compliance
Kind/DevOps
CI/CD, releases, etc
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Performance
Gotta go fast
Kind/Security
This is security issue
Kind/Technical Improvement
Underlying technical improvement that is not necessarily user-impacting or visible.
Kind/Testing
Issue or pull request related to testing
Kind/UX
Related to user experience/product
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Size
L
 Significant change
Size
M
 Medium-size change
Size
S
 Small change
Size
XL
 Very large change that might take months to complete and impact many components
Size
XS
 Trivially small change
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Status
Needs Design
 Requires design/review from Alchemists (product/UX)
Status
Needs Discussion
 A discussion needs to happen before implementation
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
conjured/silverfish!183
Reference in a new issue
conjured/silverfish
No description provided.
Delete branch "SpencerFabricant/sfab_silverfish:add_musl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?