This PR hopefully adds steps to the release flow enabling silverfish to be built for distros such as alpine. It installs the musl-dev package and targets the appropriate uh, targets. I elected not to touch the Justfile partly out of not being familiar with just. This could stand to be DRY'd up and I might refactor things a bit before merging (or later).
WIP: Enable building with musl for non glibc distros (e.g alpine) #161
150_musl_build into main
Related to issue #150
currently testing this on my own fork. Do you have a test instance of this?
testing this with adding targets: x86_64-unknown-linux-gnu, aarch64-unknown-linux-gnu, x86_64-unknown-linux-musl, aarch64-unknown-linux-musl to the Set Up Rust
This will also need a new workflow under .forgego/workflows/ci-musl*.yml
looks like that change still failed for aarch64-unknown-linux-musl. Investigating...
by the way, if you want to test this yourself, you should configure your own fork of the project and either merge the proposed changes into main or change the default branch to this one. Then push tags to to the fork
but that does have some overhead if you have not configured a forgejo runner before
even with those changes, the aarch64 musl build fails at ring.
https://github.com/briansmith/ring/issues/1414
This is a known issue, unfortunately. Investigating...
this may require building in a separate docker container
@SpencerFabricant wrote in #161 (comment):
even with those changes, the aarch64 musl build fails at
ring.https://github.com/briansmith/ring/issues/1414
This is a known issue, unfortunately. Investigating...
Yep, I was having this problem trying to compile locally. I was hoping (naively it turns out) that installing musl-dev would fix it. I'll try spinning up a local alpine container at some point soon and seeing how it goes.
I wouldn't mind just adding musl for x86_64, for now, and leaving aarch64 musl alone until we have an ask for it.
could you add the x86_64 musl build in the build-and-test part of CI as well, as a new CI job? we'll need to be running tests for it if we want to include it in releases.
I have what is hopefully a working version forked from this branch
It might be a little bit until I have the time to get back to this, please feel free to run with whatever you need to do.
This PR can be closed #183
Pull request closed
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?