Should be from watergardens to dandenong but I have no clue how to specify that
WIP: Add Metro Tunnel #41
eatham/comaps-subways:master into master
hopefully this is correct Signed-off-by: eatham <ethan@grobin.com.au>
Signed-off-by: eatham <ethan@grobin.com.au>
This is just a new blank line? Emulate the existing RER networks but edited to apply to this network
There is a Melbourne Metro Tunnel line added in the end, but CB diff doesn't highlight it for some reason..
Yes, i've added it at the bottom. Have I done it correctly? It is odd that I do not have to specify which stations and line need to be enabled
I assume the system would just take all of the interconnected stations / lines fitting into the bounding box.
It'd be important to specify line name explicitly only if has to be separated into a standalone network (like in London there are several networks which use different icons even).
IDK how to review the change as I've never worked with it before, so I'll leave a review for someone who knows better.
I've tested it and it breaks the extraction of data completely https://codeberg.org/comaps/comaps/actions/runs/14441/jobs/1/attempt/1
Invalid location in boundary (multi)polygon: (-37.460688, 144.644623).
PBF error: blob contains no data or unknown compression method
Looks like wrong bbox is specified
The bbox is most of melbourne because I assumed I needed to cover the whole line (it's a cross city line). What am I actually meant to do?
Looks like lat/lon order is wrong in your definition, e.g. compare yours -37.460688,144.644623,-38.161016,145.384827 to existing working Sydney 150.6493,-34.1441,151.2582,-33.5787
I've changed lat/lon order in the bbox
-337,Melbourne,Australia,Australia,29,1,0,0,"-37.460688,144.644623,-38.161016,145.384827",train:Metro Tunnel,,,,
+337,Melbourne,Australia,Australia,29,1,0,0,"144.644623,-37.460688,145.384827,-38.161016",train:Metro Tunnel,,,,
and subways processing didn't crash, however Metro Tunnel hasn't validated anyway:
After some investigation, I still see multiple issues here:
- I managed to get what seams to be the right dataset locally by also switching the positions of the latitudes (lowest first):
144.644623,-38.161016,145.384827,-37.460688 - The network seems to be called "PTV - Metropolitan Trains" in OSM instead of Metro Tunnel. This network also includes other lines not going through the new tunnel.
- Some of the lines however, are grouped in multiple route masters in OSM, which makes it difficult to process them down to single lines, causing errors. (Not sure how to solve this)
- If these errors would be resolved, there would still be quite some errors of stop_positions that lack a stop_area connecting them to a station, which would need to be solved in OSM.
Hope this helps, as I won't be able to work on this right now.
If the train: uses the network tag it needs to be ignored as we are currently in the process of updating network tags. Iirc the line from watergardens to dandy is the only one with 10min frequency every day so the others need to be ignored if possible. Is there no way to specify a route relation?
For missing osm info I would have to ask the pt community if they can fix them as I do not know how to, but first the other issues will have to be solved.
Train:Metro Tunnel definitely has to be removed; I might try run it without it, but that may get unrelated stations.
Closing for now, can be reopened after fixing tagging in osm
Pull request closed
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?