fix: collect garbage when saving document #113

mahlzahn commented 2026年03月04日 12:55:30 +01:00

See note at https://pymupdf.readthedocs.io/en/latest/page.html#Page.apply_redactions:

Text contained in a redaction rectangle will be physically removed from the page (assuming Document.save() with a suitable garbage option) and will no longer appear in e.g. text extractions or anywhere else. All redaction annotations will also be removed. Other annotations are unaffected.

I couldn’t find a simple reproducer to test that it is indeed a security issue, thus no test has been added for this change.

See note at https://pymupdf.readthedocs.io/en/latest/page.html#Page.apply_redactions: > Text contained in a redaction rectangle will be physically removed from the page (assuming `Document.save()` with a **suitable garbage** option) and will no longer appear in e.g. text extractions or anywhere else. All redaction annotations will also be removed. Other annotations are unaffected. I couldn’t find a simple reproducer to test that it is indeed a security issue, thus no test has been added for this change.

censor-bot commented 2026年03月04日 12:56:16 +01:00

Note

The build job for e0846b949a finished with status success. Install and run the x86_64 test build with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6236929/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel

> **Note** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6236929) for e0846b949a8f0c030515917d2c1aba5280f57733 finished with status **success**. Install and run the x86_64 test build with: > > curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6236929/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak > flatpak install --user censor-dev.flatpak > flatpak run --user page.codeberg.censor.Censor.Devel