nix: add environment variables for external tools used during build #341

ddogfoodd commented 2026年07月13日 14:34:52 +02:00

This seems to build fine for me.

We don't need Python to build under Nix, is that correct?
Do we skip the part where Python would be used?

Note that I had to add a patchPhase before the buildPhase to replace /bin/bash and uname by their binaries in the nix-store.
I'm not sure if you want to add PHOENIX_BASH and PHOENIX_UNAME. If you do, we can remove the patchPhase again. I don't wanted to burden the build scripts any further with nix specifics, so I thought patching it in the nix files is the way to go.

This seems to build fine for me. We don't need Python to build under Nix, is that correct? Do we skip the part where Python would be used? Note that I had to add a `patchPhase` before the `buildPhase` to replace `/bin/bash` and `uname` by their binaries in the nix-store. I'm not sure if you want to add `PHOENIX_BASH` and `PHOENIX_UNAME`. If you do, we can remove the `patchPhase` again. I don't wanted to burden the build scripts any further with nix specifics, so I thought patching it in the nix files is the way to go.

celenity commented 2026年07月14日 03:52:59 +02:00

Thank you for the PR!!

@ddogfoodd wrote in #341 (comment):

We don't need Python to build under Nix, is that correct?

Well, Python is actually needed for OS X (for policies), but not on Linux - not sure what the best way to handle that would be.

Note that I had to add a patchPhase before the buildPhase to replace /bin/bash and uname by their binaries in the nix-store.

Sounds fine for /bin/bash (at least for now), but yeah I do think we should add an env var for uname. I can take a look at that if you don't want to cover it in this PR.

Thank you for the PR!! @ddogfoodd wrote in https://codeberg.org/celenity/Phoenix/pulls/341#issue-6263753: > We don't need Python to build under Nix, is that correct? Well, Python is actually needed for OS X *(for policies)*, but not on Linux - not sure what the best way to handle that would be. > Note that I had to add a `patchPhase` before the `buildPhase` to replace `/bin/bash` and `uname` by their binaries in the nix-store. Sounds fine for `/bin/bash` *(at least for now)*, but yeah I do think we should add an env var for `uname`. I can take a look at that if you don't want to cover it in this PR.

celenity commented 2026年07月14日 05:13:11 +02:00

@celenity wrote in #341 (comment):

but yeah I do think we should add an env var for uname. I can take a look at that if you don't want to cover it in this PR.

I went ahead and added PHOENIX_UNAME - ab55779673

@celenity wrote in https://codeberg.org/celenity/Phoenix/pulls/341#issuecomment-19176071: > but yeah I do think we should add an env var for `uname`. I can take a look at that if you don't want to cover it in this PR. I went ahead and added `PHOENIX_UNAME` - https://codeberg.org/celenity/Phoenix/commit/ab55779673ba88b7fc720014776b09436215ca6a

ddogfoodd commented 2026年07月14日 06:43:39 +02:00

Rebased to latest dev.
Replaced the uname patch with setting as env var.
Added python3 for darwin only.

Only tested on x86_64-linux though. Darwin testers welcome, else feel free to mention me if you open an issue.

Rebased to latest dev. Replaced the `uname` patch with setting as env var. Added `python3` for darwin only. Only tested on x86_64-linux though. Darwin testers welcome, else feel free to mention me if you open an issue.

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

You are not authorized to merge this pull request.