nix: set PHOENIX_* of build tools to bins in nix-store #337

ddogfoodd commented 2026年07月10日 19:06:48 +02:00

Setting environment variables of tools used during build to lead to the
binaries in nix-store.
This way, we can remove some checks for PHOENIX_NIX in the build
scripts.
Skipping uv for now, as I don't think we will use it on nix. Just as we
didn't use pyenv.

Setting environment variables of tools used during build to lead to the binaries in nix-store. This way, we can remove some checks for PHOENIX_NIX in the build scripts. Skipping uv for now, as I don't think we will use it on nix. Just as we didn't use pyenv.

ddogfoodd commented 2026年07月10日 19:14:46 +02:00

If you don't mind it would be great to backport this to the pages branch as well, so the new release for nix users isn't broken until the next one lands. (Same for dove)

If you don't mind it would be great to backport this to the `pages` branch as well, so the new release for nix users isn't broken until the next one lands. (Same for dove)

degausser commented 2026年07月10日 21:14:35 +02:00

actually closes #335 i guess...

this seems like the proper fix for nix, why not also set all the other PHOENIX_* tools this way?
does /bin/date (PHOENIX_DATE) work?

_actually_ closes https://codeberg.org/celenity/Phoenix/issues/335 i guess... this seems like the proper fix for nix, why not also set all the [other PHOENIX_* tools](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/scripts/env_common.sh#L140-197) this way? does `/bin/date` (`PHOENIX_DATE`) [work](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/scripts/fly.sh#L102-L103)?

ddogfoodd commented 2026年07月11日 08:00:10 +02:00

@degausser wrote in #337 (comment):

this seems like the proper fix for nix, why not also set all the other PHOENIX_* tools this way? does /bin/date (PHOENIX_DATE) work?

You are right, we should probably do that. E.g. to not break the nix build when another default changes. I will take a look and add them.

@degausser wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18966380: > this seems like the proper fix for nix, why not also set all the [other PHOENIX_* tools](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/scripts/env_common.sh#L140-197) this way? does `/bin/date` (`PHOENIX_DATE`) [work](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/scripts/fly.sh#L102-L103)? You are right, we should probably do that. E.g. to not break the nix build when another default changes. I will take a look and add them.

celenity commented 2026年07月11日 09:15:38 +02:00

@ddogfoodd wrote in #337 (comment):

@degausser wrote in #337 (comment):

this seems like the proper fix for nix, why not also set all the other PHOENIX_* tools this way? does /bin/date (PHOENIX_DATE) work?

You are right, we should probably do that. E.g. to not break the nix build when another default changes. I will take a look and add them.

Yeah, I agree this would be ideal - so do you think we should wait to merge this until we update those other defaults as well, or should I go ahead and merge this now? (And yeah don't worry, I'll backport this fix to pages).

PS - Thanks for the PR here!

@ddogfoodd wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18994016: > @degausser wrote in #337 (comment): > > > this seems like the proper fix for nix, why not also set all the [other PHOENIX_* tools](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/scripts/env_common.sh#L140-197) this way? does `/bin/date` (`PHOENIX_DATE`) [work](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/scripts/fly.sh#L102-L103)? > > You are right, we should probably do that. E.g. to not break the nix build when another default changes. I will take a look and add them. Yeah, I agree this would be ideal - so do you think we should wait to merge this until we update those other defaults as well, or should I go ahead and merge this now? *(And yeah don't worry, I'll backport this fix to `pages`)*. PS - Thanks for the PR here!

ddogfoodd commented 2026年07月11日 09:18:31 +02:00

@celenity wrote in #337 (comment):

Yeah, I agree this would be ideal - so do you think we should wait to merge this until we update those other defaults as well, or should I go ahead and merge this now? (And yeah don't worry, I'll backport this fix to pages).

Just pushed and tested. Feel free to merge. Will do Dove later.

@celenity wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18995654: > Yeah, I agree this would be ideal - so do you think we should wait to merge this until we update those other defaults as well, or should I go ahead and merge this now? _(And yeah don't worry, I'll backport this fix to `pages`)_. Just pushed and tested. Feel free to merge. Will do Dove later.

degausser commented 2026年07月11日 10:11:10 +02:00

9ebbbec97f should be reverted when this lands.
also this seems useless, since the pref isn't included in the config anyways.

---

pro futuro,

I'll also note that it's possible use your own Python/system Python if preferred, instead of downloading it from get_sources.sh, by setting PHOENIX_PYTHON to point to your desired location of Python, and by creating your own virtual environment + setting PHOENIX_PYENV_DIR to the path of that environment (I would definitely like to document this though, as well as the other variables).

should be applied to the nix build process, which would make s3cmd, awk (PHOENIX_AWK is only used in get_sources_phoenix.sh) unnecessary. since it uses the output files directly, zip, tar (& date) shouldn't be needed too (fly.sh needs a flag/envvar to not create the archives), so only sed.

https://codeberg.org/celenity/Phoenix/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e should be reverted when this lands. also [this](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/nix/package.nix#L22) seems useless, since the pref isn't included in the config anyways. ___ _pro futuro_, >I'll also note that it's possible use your own Python/system Python if preferred, instead of downloading it from get_sources.sh, by setting PHOENIX_PYTHON to point to your desired location of Python, and by creating your own virtual environment + setting PHOENIX_PYENV_DIR to the path of that environment (I would definitely like to document this though, as well as the other variables). should be applied to the nix build process, which would make s3cmd, awk (PHOENIX_AWK is only used in get_sources_phoenix.sh) unnecessary. since it uses the output files directly, zip, tar (& date) shouldn't be needed too (fly.sh needs a flag/envvar to _not create the archives_), so only sed.

ddogfoodd commented 2026年07月11日 10:13:58 +02:00

You are right, I just added every PHOENIX_* I saw in fly.sh, removing. What about awk and date? Since the build didn't fail without replacing their bin paths...
Sed did work before because it was set to just sed on Nix.

You are right, I just added every PHOENIX_* I saw in fly.sh, removing. What about awk and date? Since the build didn't fail without replacing their bin paths... Sed did work before because it was set to just `sed` on Nix.

ddogfoodd commented 2026年07月11日 10:19:28 +02:00

@degausser wrote in #337 (comment):

should be applied to the nix build process, which would make s3cmd, awk (PHOENIX_AWK is only used in get_sources_phoenix.sh) unnecessary. since it uses the output files directly, zip, tar (& date) shouldn't be needed too (fly.sh needs a flag/envvar to not create the archives), so only sed.

So don't call the create_archive function when PHOENIX_NIX is set or are there further conditions in which not to create an archive?

@degausser wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18997142: > should be applied to the nix build process, which would make s3cmd, awk (PHOENIX_AWK is only used in get_sources_phoenix.sh) unnecessary. since it uses the output files directly, zip, tar (& date) shouldn't be needed too (fly.sh needs a flag/envvar to _not create the archives_), so only sed. So don't call the `create_archive` function when PHOENIX_NIX is set or are there further conditions in which not to create an archive?

celenity commented 2026年07月11日 10:21:17 +02:00

@ddogfoodd wrote in #337 (comment):

What about awk and date? Since the build didn't fail without replacing their bin paths...

IMO we should probably keep awk and date, because they are used directly by the build scripts (which could impact Nix) - ex. date is used for producing the output archives and awk is used for parsing inputs for some of the scripts (I don't think it's technically used directly by fly.sh at the moment though, but it could/will likely be in the future).

@ddogfoodd wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18997205: > What about awk and date? Since the build didn't fail without replacing their bin paths... IMO we should probably keep `awk` and `date`, because they are used directly by the build scripts *(which could impact Nix)* - ex. `date` is used for producing the output archives and `awk` is used for parsing inputs for some of the scripts *(I don't think it's technically used directly by `fly.sh` at the moment though, but it could/will likely be in the future)*.

celenity commented 2026年07月11日 10:22:49 +02:00

@ddogfoodd wrote in #337 (comment):

So don't call the create_archive function when PHOENIX_NIX is set or are there further conditions in which not to create an archive?

No, create_archive is actually always called ATM - that being said, I do need to/intend to add an env variable to support disabling it. Once we add it, we can probably set it to the default for Nix builds, and then at that point, we can safely remove date - but we probably need to keep it for now since we don't yet have a mechanism to disable it.

@ddogfoodd wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18997274: > So don't call the `create_archive` function when PHOENIX_NIX is set or are there further conditions in which not to create an archive? No, `create_archive` is actually always called ATM - that being said, I do need to/intend to add an env variable to support disabling it. Once we add it, we can probably set it to the default for Nix builds, and then at that point, we can safely remove `date` - but we probably need to keep it for now since we don't yet have a mechanism to disable it.

celenity commented 2026年07月11日 10:34:35 +02:00

@degausser wrote in #337 (comment):

9ebbbec97f should be reverted when this lands.

Yeah, it looks like the changes here should revert that.

also this seems useless, since the pref isn't included in the config anyways.

Agreed - I'm honestly not sure why it was ever added in the first place - guessing it was just something that got added a long time ago. Good catch!

@degausser wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18997142: > [`9ebbbec97f`](https://codeberg.org/celenity/Phoenix/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e) should be reverted when this lands. Yeah, it looks like the changes here should revert that. > also [this](https://codeberg.org/celenity/Phoenix/src/commit/9ebbbec97fdf043550fe9ad139e3637a5004e63e/nix/package.nix#L22) seems useless, since the pref isn't included in the config anyways. Agreed - I'm honestly not sure why it was ever added in the first place - guessing it was just something that got added a long time ago. Good catch!

ddogfoodd commented 2026年07月11日 10:36:42 +02:00

Thank you all too!

Thank you all too!

celenity commented 2026年07月11日 10:49:28 +02:00

FYI: I just went ahead and added support for the env variable to disable archive creation (defaults to disabled for Nix) - ff537c0f75 - I also went ahead and removed the dependency on date for Nix, since we'll no longer need it for future releases.

FYI: I just went ahead and added support for the env variable to disable archive creation *(defaults to disabled for Nix)* - https://codeberg.org/celenity/Phoenix/commit/ff537c0f754a8a9d875528b2702e9c5ed535c6bf - I also went ahead and removed the dependency on `date` for Nix, since we'll no longer need it for future releases.

celenity commented 2026年07月11日 10:51:07 +02:00

@celenity wrote in #337 (comment):

FYI: I just went ahead and added support for the env variable to disable archive creation (defaults to disabled for Nix) - ff537c0f75 - I also went ahead and removed the dependency on date for Nix, since we'll no longer need it for future releases.

Occurred to me we should no longer need GNU tar as well, so I went ahead and removed that too.

@celenity wrote in https://codeberg.org/celenity/Phoenix/pulls/337#issuecomment-18998279: > FYI: I just went ahead and added support for the env variable to disable archive creation _(defaults to disabled for Nix)_ - [`ff537c0f75`](https://codeberg.org/celenity/Phoenix/commit/ff537c0f754a8a9d875528b2702e9c5ed535c6bf) - I also went ahead and removed the dependency on `date` for Nix, since we'll no longer need it for future releases. Occurred to me we should no longer need GNU tar as well, so I went ahead and removed that too.

degausser commented 2026年07月11日 11:00:14 +02:00

@celenity TZ manipulation should depend on PHOENIX_PRODUCE_ARCHIVES, since it's relevant only for date; just touch-ing the output files is meaningless for "reproducibility"

also we can ducttape the current scripts all we want, but it's obvious fly.sh should be callable on its own, without get_sources{,_phoenix}.sh via build.sh, which would alleviate a lot of related packaging problems (see the debian issue)

@celenity `TZ` manipulation should depend on `PHOENIX_PRODUCE_ARCHIVES`, since it's relevant only for `date`; just touch-ing the output files is meaningless for "reproducibility" also we can ducttape the current scripts all we want, but it's obvious `fly.sh` should be callable on its own, without `get_sources{,_phoenix}.sh` via `build.sh`, which would alleviate a lot of related packaging problems (see the debian issue)