bg443/BikeBridge
1
10
Fork
You've already forked BikeBridge
3

Prepare Bosch BLE infrastructure and logging #19

Open
stereodreieck86 wants to merge 1 commit from stereodreieck86/BikeBridge:pr1-bosch-infrastructure into master
pull from: stereodreieck86/BikeBridge:pr1-bosch-infrastructure
merge into: bg443:master
bg443:master

Summary

This PR prepares the Bosch BLE infrastructure for future work.

Changes:

  • add Bosch BLE constants
  • add Bosch GATT name mapping
  • improve GATT discovery logging with Bosch-specific names

No functional Bosch protocol parsing is included yet.
This PR only lays the groundwork for future development.

## Summary This PR prepares the Bosch BLE infrastructure for future work. Changes: - add Bosch BLE constants - add Bosch GATT name mapping - improve GATT discovery logging with Bosch-specific names No functional Bosch protocol parsing is included yet. This PR only lays the groundwork for future development.
Prepare Bosch BLE infrastructure and logging
Some checks failed
Build debug / build (pull_request) Failing after 2m44s
13016c0478
Owner
Copy link

I see some of this is present in #14 - can you confirm what the plan is? Which PRs should I be looking at?

Thanks

I see some of this is present in https://codeberg.org/bg443/BikeBridge/pulls/14 - can you confirm what the plan is? Which PRs should I be looking at? Thanks
bg443 left a comment
Copy link

Just minor changes - rest looks good to me

Just minor changes - rest looks good to me
@ -156,1 +168,4 @@
val EBD0 = 0xEBD0.getBoschBluetoothUUID()
}
// <<< DIESE KLAMMER FEHLT >>>
Owner
Copy link

Can we remove this?

Can we remove this?
stereodreieck86 marked this conversation as resolved
@ -132,0 +193,4 @@
uuid == BleConstants.Characteristics.Bosch.EBD0 ||
isBoschLdi(uuid)
@Deprecated("Use top-level getGattName instead", ReplaceWith("BikeUtil.getGattName(uuid)"))
Owner
Copy link

Can we just remove this?

Can we just remove this?
Author
Contributor
Copy link

Yes

Yes
stereodreieck86 marked this conversation as resolved
Some checks failed
Build debug / build (pull_request) Failing after 2m44s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u pr1-bosch-infrastructure:stereodreieck86-pr1-bosch-infrastructure
git switch stereodreieck86-pr1-bosch-infrastructure

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff stereodreieck86-pr1-bosch-infrastructure
git switch stereodreieck86-pr1-bosch-infrastructure
git rebase master
git switch master
git merge --ff-only stereodreieck86-pr1-bosch-infrastructure
git switch stereodreieck86-pr1-bosch-infrastructure
git rebase master
git switch master
git merge --no-ff stereodreieck86-pr1-bosch-infrastructure
git switch master
git merge --squash stereodreieck86-pr1-bosch-infrastructure
git switch master
git merge --ff-only stereodreieck86-pr1-bosch-infrastructure
git switch master
git merge stereodreieck86-pr1-bosch-infrastructure
git push origin master
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bg443/BikeBridge!19
Reference in a new issue
bg443/BikeBridge
No description provided.
Delete branch "stereodreieck86/BikeBridge:pr1-bosch-infrastructure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?