bg443/BikeBridge
1
10
Fork
You've already forked BikeBridge
3

Add Bosch LDI protobuf scaffolding #21

Merged
bg443 merged 1 commit from stereodreieck86/BikeBridge:pr3-bosch-protobuf into master 2026年07月08日 19:04:47 +02:00

Summary

This PR adds the initial protobuf scaffolding for Bosch LDI.

Included

  • Bosch LDI .proto definition
  • Required Gradle configuration
  • Version catalog updates

Not included

  • Message decoding
  • Parser
  • BLE notification handling
  • UI integration

This PR only prepares the project structure for future Bosch LDI support.

## Summary This PR adds the initial protobuf scaffolding for Bosch LDI. ### Included - Bosch LDI .proto definition - Required Gradle configuration - Version catalog updates ### Not included - Message decoding - Parser - BLE notification handling - UI integration This PR only prepares the project structure for future Bosch LDI support.
Add Bosch LDI protobuf scaffolding
All checks were successful
Build debug / build (pull_request) Successful in 3m18s
40a4383e2a
Owner
Copy link

I see this is present in #14 - can you confirm what the plan is? Which PRs should I be looking at?

Thanks

I see this is present in https://codeberg.org/bg443/BikeBridge/pulls/14 - can you confirm what the plan is? Which PRs should I be looking at? Thanks
Author
Contributor
Copy link

hanks for pointing that out. You're right that there is currently some overlap because I split the Bosch work into several incremental PRs while the architecture evolved.

The intended order is:

#21 – Protobuf scaffolding only (.proto definition + Gradle setup). No functional changes.
#19 – BLE infrastructure and logging improvements required for Bosch device exploration.
#15 – Incremental Bosch Smart System integration building on the previous infrastructure.
#14 – Replay framework, which is largely independent but provides tooling for protocol analysis and regression testing.

During development some later branches temporarily contained commits from earlier work, which is why parts of the scaffolding are visible in multiple PRs.

To make reviewing easier, I can also rebase or clean up the branches so each PR contains only its intended scope.

hanks for pointing that out. You're right that there is currently some overlap because I split the Bosch work into several incremental PRs while the architecture evolved. The intended order is: #21 – Protobuf scaffolding only (.proto definition + Gradle setup). No functional changes. #19 – BLE infrastructure and logging improvements required for Bosch device exploration. #15 – Incremental Bosch Smart System integration building on the previous infrastructure. #14 – Replay framework, which is largely independent but provides tooling for protocol analysis and regression testing. During development some later branches temporarily contained commits from earlier work, which is why parts of the scaffolding are visible in multiple PRs. To make reviewing easier, I can also rebase or clean up the branches so each PR contains only its intended scope.
@ -74,3 +74,3 @@
// True, if the system is in a locked state.
optional bool system_locked = 21;
// True, if the charger is currently connected. This doesnt necessarily mean that the bike is currently charging (e.g. when battery is already full).
// True, if the charger is currently connected. This doesnt necessarily mean that the bike is currentl charging (e.g. when battery is already full).
Owner
Copy link

This should have the y 😄

This should have the `y` 😄
Owner
Copy link
https://codeberg.org/bg443/BikeBridge/commit/36683551208d5225f647830276dcf0955c2d4bd5
stereodreieck86 marked this conversation as resolved
Owner
Copy link

Great thank you. I will be sure to review them in that order

Great thank you. I will be sure to review them in that order
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bg443/BikeBridge!21
Reference in a new issue
bg443/BikeBridge
No description provided.
Delete branch "stereodreieck86/BikeBridge:pr3-bosch-protobuf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?